Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321331

Summary:	[sync] NPE when committing from synchronize view
Product:	[Technology] EGit	Reporter:	Ilya Klyuchnikov <ilya.klyuchnikov>
Component:	UI	Assignee:	Matthias Sohn <matthias.sohn>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	caniszczyk, dariusz.luksza, eclipse.org, stefan.lay
Version:	0.9.0
Target Milestone:	0.10.0-M3
Hardware:	All
OS:	All
Whiteboard:

Description Ilya Klyuchnikov

2010-07-30 08:22:57 EDT

This is for egit 0.9.0.201007281519

I select project > Team > Synchronize 
Then I select check "Include local uncommitted changes in comparison"

Synchronize view is populated, I select uncommitted changes in this view > "Commit .." and get NPE:


org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
at org.eclipse.swt.SWT.error(SWT.java:4083)
at org.eclipse.swt.SWT.error(SWT.java:3998)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:137)
...
Caused by: java.lang.NullPointerException
at org.eclipse.egit.ui.internal.actions.RepositoryAction.run(RepositoryAction.java:69)
at org.eclipse.egit.ui.internal.synchronize.CommitOperation$2.run(CommitOperation.java:47)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
... 47 more

Comment 1 François Rey

2010-09-19 05:00:41 EDT

I think I also have this with 0.9.3 except eclipse crashes on me and I have no way to check it was an npe (it's a jvm crash and I could not find any log anywhere). But the way to reproduce the crash is the same as described by original poster.
I'm on arch linux 64 bits, eclipse helios

Comment 2 Chris Aniszczyk

2010-12-03 10:19:32 EST

Fixed with http://egit.eclipse.org/r/#change,2018