Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321306

Summary:	Convert line delimiters should report ignored binary files
Product:	[Eclipse Project] Platform	Reporter:	Krzysztof Daniel <krzysztof.daniel>
Component:	Text	Assignee:	Markus Keller <markus.kell.r>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	daniel_megert, david_williams, markus.kell.r, prakash
Version:	3.4.2
Target Milestone:	4.3 M3
Hardware:	All
OS:	All
Whiteboard:

Description Krzysztof Daniel

2010-07-30 05:12:04 EDT

If you create a file in Package Explorer, and its type is binary (f.e. extension xyz), the convert line delimeters is active if the file is selected, however the action silently fails. 

It works for txt extension.

The action should either be inactive, or give error message.

Comment 1 Prakash Rangaraj

2010-07-30 05:51:44 EDT

How did you change the delimiter for a file? Delimiter information is available only on the Properties of the Project - not on the Properties of a file.

Comment 2 Eric Moffatt

2010-08-17 14:32:17 EDT

Just to clarify...is it just that the command is enabled when it should be disabled? If so I'll pass it on, if not please provide more info...

Comment 3 Francis Upton IV

2010-11-02 03:33:05 EDT

Guess this is related to the ConvertLineDelimitersAction which is part of text.

Comment 4 Markus Keller

2012-10-05 10:14:54 EDT

Fixed with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=557ba618fc1d1f0161c453067e6b17fd848148b9

- shows a dialog if non-text files are selected
  - still converts without dialog if invoked from a text editor
- allows to see non-text files in the selection dialog