Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321090

Summary: [Dawn] Do not Require-Bundle plug-ins that are not provided by Eclipse.org
Product: [Modeling] EMF Reporter: Eike Stepper <stepper>
Component: cdo.dawnAssignee: Martin Fluegge <martin.fluegge>
Status: CLOSED FIXED QA Contact: Eike Stepper <stepper>
Severity: normal    
Priority: P3 Flags: stepper: review+
Version: 4.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description Eike Stepper CLA 2010-07-28 02:39:09 EDT 
We should depend on external components through Import-Package headers to enable users/deployers to choose different implementations.

I've found this in the org.eclipse.emf.cdo.dawn.codegen manifest:

Require-Bundle: com.ibm.icu;bundle-version="[4.0.0,5.0.0)",
 org.apache.commons.logging;bundle-version="[1.1.0,2.0.0)",
 org.apache.commons.lang;bundle-version="[2.3.0,3.0.0)",
 org.antlr.runtime;bundle-version="[3.0.0,4.0.0)",
Comment 1 Martin Fluegge CLA 2010-07-30 09:56:23 EDT 
Created attachment 175577 [details]
Patch v1

Ah. I see. Thanks for pointing me to this :)

I also had to add org.eclipse.emf.mwe2.runtime to the resolve its log4j dependency and make it available in the target platform. That's why I attached the changes as patch.
Comment 2 Eike Stepper CLA 2010-08-06 08:52:43 EDT 
The patch was out of sync but please go ahead and commit. I'll take a look from time to time ;-)
Comment 3 Martin Fluegge CLA 2010-08-06 11:32:45 EDT 
Created attachment 176047 [details]
Patch v2

Ah, I see. I had changed the buckminster.cspec during another commit. For good order's sake I fixed the patch :)

Committed to HEAD.
Comment 4 Martin Fluegge CLA 2010-08-06 11:38:02 EDT 
Closed. If I do it again wrong, please re-open. 

But I promise that I'll handle this topic more carefully in the future ;)
Comment 5 Eike Stepper CLA 2011-06-23 03:40:54 EDT 
Available in R20110608-1407