Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321069

Summary:

ASTWriter fails on IASTDeclarators with nested declarators

Product:

[Tools] CDT

Reporter:

Tomasz Wesolowski <kosashi>

Component:

cdt-core

Assignee:

Elena Laskavaia <elaskavaia.cdt>

Status:

RESOLVED FIXED

QA Contact:

Doug Schaefer <cdtdoug>

Severity:

normal

Priority:

CC:

eclipse.sprigogin, elaskavaia.cdt

Version:

7.0

Target Milestone:

7.0.1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
test case	none
fix	elaskavaia.cdt: iplog+
test case	elaskavaia.cdt: iplog+

Description Tomasz Wesolowski

2010-07-27 17:39:07 EDT

Some complex declarators are written improperly because simple IASTDeclarators' nested declarators are ignored (as opposed to IASTArrayDeclarators or IASTFunctionDeclarators).

Comment 1 Tomasz Wesolowski

2010-07-27 17:39:28 EDT

Created attachment 175360 [details]
test case

Comment 2 Tomasz Wesolowski

2010-07-27 17:40:31 EDT

Created attachment 175361 [details]
fix

one small line for code, one giant difference for tests

Comment 3 Tomasz Wesolowski

2010-07-27 18:54:25 EDT

Created attachment 175362 [details]
test case

accidentally slipped bug 319044 test into the patch; fixed

Comment 4 Elena Laskavaia

2010-08-01 19:52:12 EDT

I think it should go to 7.0.1

Comment 5 CDT Genie

2010-08-01 20:23:02 EDT

*** cdt cvs genie on behalf of elaskavaia ***
Bug 321069 ASTWriter fails on IASTDeclarators with nested declarators, patch from Tomasz Wesolowski

[*] DeclaratorWriter.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/astwriter/DeclaratorWriter.java?root=Tools_Project&r1=1.7&r2=1.8

[*] ASTWriterDeclaratorTestSource.awts 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/resources/rewrite/ASTWriterDeclaratorTestSource.awts?root=Tools_Project&r1=1.5&r2=1.6

[*] DeclaratorWriter.java 1.6.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/astwriter/DeclaratorWriter.java?root=Tools_Project&r1=1.6&r2=1.6.2.1

[*] ASTWriterDeclaratorTestSource.awts 1.4.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/resources/rewrite/ASTWriterDeclaratorTestSource.awts?root=Tools_Project&r1=1.4&r2=1.4.2.1

Comment 6 Elena Laskavaia

2010-08-01 21:43:56 EDT

I think it should go to 7.0.1

Comment 7 Elena Laskavaia

2010-08-01 21:44:30 EDT

patch applied to 7.0.1 and 8.0, thanks

Comment 8 CDT Genie

2011-01-06 03:23:01 EST

*** cdt cvs genie on behalf of egraf ***
Bug 321069 - ASTWriter fails on IASTDeclarators with nested declarators
Test failed in 7.0

[*] ASTWriterDeclaratorTestSource.awts 1.4.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core.tests/resources/rewrite/ASTWriterDeclaratorTestSource.awts?root=Tools_Project&r1=1.4.2.1&r2=1.4.2.2