Bugzilla – Full Text Bug Listing
| Summary: | [API] Helios JSFAppConfigManager APIs are marked internal | ||
|---|---|---|---|
| Product: | [WebTools] Java Server Faces | Reporter: | Xiaonan Jiang <xiaonan_jiang> |
| Component: | JSF Tools | Assignee: | Gerry Kessler <gerry.kessler> |
| Status: | ASSIGNED --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | raghunathan.srinivasan, yurykats |
| Version: | unspecified | ||
| Target Milestone: | Future | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
Passing over to Gerry, since he did the work on 308419. Splitting out the second part of this to bug 323436. This bug has also been renamed to be more descriptive. Xiaonan, please create new bugs if you find any additional APIs that you use that are marked internal and should be made public. Since this requires changes to API, we will target this for the Indigo release. Hi Xiaonan, I'm sorry that this fell off of our radar; it has become almost too late to fix at this time. How critical is this fix for you in the Indigo release? Are you currently using these internally packaged APIs? GK Deferring due to lack of resources. |
Build Identifier: wtp 3.2 I tried to extend the JsfAppConfigManager using the following feature in bugzilla #308419: "An orthogonal feature will also be to given to allow adopters to provide their own set of IJSFAppConfigLocators that the JSFAppConfigManager will use to locate faces configuration elements." There are some issues: 1) The following two classes need to be public APIs (A) org.eclipse.jst.jsf.core.jsfappconfig.internal.IJSFAppConfigLocatorProvider When I define a "org.eclipse.jst.jsf.core.jsfAppConfigLocatorProviderFactory" extension, I need to implement my own IJSFAppConfigLocatorProvider. (B) org.eclipse.jst.jsf.core.jsfappconfig.internal.IJSFAppConfigManager I need to call IJSFAppConfigManager.getProject() method. 2) Can't guarantee the extended LocatorProvider will be picked up each time In the CompositeFactorySelectionStrategyProvider.getFactoryToUse() method in JSFAppConfigManagerFactory.java, it calls providerSelector.perform(project) method. In the perform() method, it uses an iterator for a HashMap to find the first LocatorProvider. If DefaultJSFAppConfigManagerProviderStrategy is searched before ExtensionBasedJSFAppConfigManagerProviderStrategy, the DefaultProvider instead of my extended LocatorProvider will be returned. Reproducible: Always