Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321018

Summary:

Commit dialog: embedded compare editor instead of opening a new window

Product:

[Technology] EGit

Reporter:

Benjamin Muskalla <b.muskalla>

Component:

Assignee:

Project Inbox <egit.ui-inbox>

Status:

NEW ---

QA Contact:

Severity:

enhancement

Priority:

CC:

davidmichaelkarr, robin

Version:

0.9.0

Keywords:

bugday, helpwanted

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
cvs dialog	none

Description Benjamin Muskalla

2010-07-27 10:08:36 EDT

The compare feature in the Commit dialog is not easy to find as nobody expects that a doubleclick does anything in that case. The CVS commit dialog has an additional button to show a compare pane to show the compare pane as part of the dialog.

In addition, a tree representation makes more sense in my eyes to show the changed files.

Will provide a patch if you want.

Comment 1 Benjamin Muskalla

2010-07-27 10:09:03 EDT

Created attachment 175318 [details]
cvs dialog

Comment 2 Stefan Lay

2010-07-27 10:51:57 EDT

There was once a longer discussion about a new commit dialog: see bug 310128.

But I think that an iterative approach is reasonable here.

Maybe we can later on add Remy's idea of a staging area  (bug 313263) to the commit dialog.

Comment 3 Robin Stocker

2013-09-27 11:35:58 EDT

Showing the compare editor within the same dialog would still be nice (although I personally only use the staging view).

Comment 4 David M. Karr

2013-11-14 16:45:37 EST

Frankly, an easier fix to this interface problem is simply to put the compare option in the right-click context menu.  Putting it on double-click is completely non-obvious.

Comment 5 Robin Stocker

2013-11-14 19:45:10 EST

(In reply to David M. Karr from comment #4)
> Frankly, an easier fix to this interface problem is simply to put the
> compare option in the right-click context menu.  Putting it on double-click
> is completely non-obvious.

See the change for this in bug 421491. Having the compare view embedded would still be nice in addition to that.