Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320987

Summary:	[Theming][Tree][Table] align CSS of Tree and Table
Product:	[RT] RAP	Reporter:	Bogdan B. <bbarzu>
Component:	RWT	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bbarzu, shashwat.work, tbuschto
Version:	1.3
Target Milestone:	1.4 M2
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	323048, 323052, 323053, 323055
Bug Blocks:	320597

Description Bogdan B.

2010-07-27 05:43:10 EDT

Build Identifier: rap-runtime-1.3.0-R-20100615-1734

As Tim suggested (https://bugs.eclipse.org/bugs/show_bug.cgi?id=314421#c5), I open a separate bug for the missing CSS for Tree:

I checked the "Themeable RWT Widgets" section of the
rap-tooling-1.3.0-R-20100615-1734.zip help and have seen that the following CSS
classes, properties, states or styles that I would need are supported by Table
but not by Tree:

Exist             Does not exist        Properties, Styles, States

Table-Cell        Tree-Cell        <at all>    
Table-GridLine        Tree-GridLine        <at all>
TableColumn        TreeColumn        color, font
TableItem        TreeItem        :even, :hover
Table-Checkbox        Tree-Checkbox        width

Could you please estimate if and when they would be available?


Reproducible: Always

Comment 1 Ralf Sternberg

2010-08-03 05:00:59 EDT

I changed the title because I think this bug is about an alignment of the CSS capabilities of Tree and Table. Replacing a Tree with a Table or vice-versa is probably a common use case and it should be possible to use the same CSS rules for both widgets with the same outcome.

(In reply to comment #0)
> Could you please estimate if and when they would be available?

I'm sure that we can fix this bug for the 1.4 release but I can't say in which milestone.

Comment 2 Bogdan B.

2010-08-17 05:19:33 EDT

Have you decided yet in which milestone you will fix this?
I am only asking because I need to make a decision: my deadline seems to be shortly after 1.4M2 (17.09.10), so will they be available in M2?

Comment 3 Ivan Furnadjiev

2010-08-17 09:04:28 EDT

Bogdan, I'm sorry to say, but it is very hard to schedule such a thing. The new client side Tree implementation still needs some additional improvements (see bug 320597). As Ralf said, we will fix it for the 1.4 release for sure.

Comment 4 Tim Buschtoens

2010-08-18 11:07:01 EDT

For my own convenience, i'll open seperate bugs for these issues.
@Bogdan B.: There is a good chance this will be fixed in M2, but no promises.

Comment 5 Tim Buschtoens

2010-08-18 11:23:46 EDT

Sorry, was closed by mistake.

Comment 6 Ivan Furnadjiev

2010-09-01 05:31:56 EDT

Fixed in CVS HEAD. The only difference is that Tree-Checkbox has "margin" property instead of "width".

Comment 7 Ralf Sternberg

2010-09-01 09:41:24 EDT

(In reply to comment #6)
> The only difference is that Tree-Checkbox has "margin" property instead of "width".

Although I agree that a "margin" property is better than "width", I don't think that this difference between Tree and Table is acceptable for end users. IIRC, "width" has been used since we wasn't able to measure the sizes of theming images back then. Now, since image sizes are available on the client, margin offers more flexibility. How about adding a "margin" property to Table too, and deprecating "width"? We should still support "width" for compatibility, but using the new property would override the old one.

Comment 8 Ivan Furnadjiev

2010-09-01 10:03:40 EDT

Completely agree with you. +1 for deprecating "width" in Table and introduce additional "margin" property.

Comment 9 Ivan Furnadjiev

2010-09-03 08:18:28 EDT

Added Table-Checkbox "margin" property as suggested in comment #7.