Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320946

Summary:

Bad comparison in ProfileBundleContainer.isContentEqual()

Product:

[Eclipse Project] PDE

Reporter:

Michael Rennie <Michael_Rennie>

Component:

Assignee:

Curtis Windatt <curtis.windatt.public>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public, darin.eclipse

Version:

3.6

Keywords:

contributed

Target Milestone:

3.6.1

Flags:

darin.eclipse: review+

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
fix	none

Description Michael Rennie

2010-07-26 14:39:21 EDT

Created attachment 175256 [details]
fix

build: I20100720-0800

The comparison in ProfileBundleContainer.isContentEqual() is bunk. You are comparing the same object against itself.

bunk code:

if (container instanceof ProfileBundleContainer) {
  ProfileBundleContainer pbc = (ProfileBundleContainer) container;
  return fHome.equals(pbc.fHome) && 
         isNullOrEqual(fConfiguration, fConfiguration);
}

Should probably be comparing to pbc.fConfiguration

Comment 1 Curtis Windatt

2010-07-26 15:20:20 EDT

Thanks Mike. Fixed in HEAD.

Comment 2 Curtis Windatt

2010-07-27 15:58:00 EDT

Reopening as a 3.6.1 candidate

Comment 3 Curtis Windatt

2010-07-27 15:59:17 EDT

Fixed in 3.6.1 Branch

Comment 4 Curtis Windatt

2010-08-30 12:58:51 EDT

Verified.