Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320937

Summary: jar's placed in Java EE 5 Ear's lib directory should never be considered "modules"
Product: [WebTools] WTP Java EE Tools Reporter: Hari Shankar <hshanka>
Component: jst.j2eeAssignee: Hari Shankar <hshanka>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc, jsholl
Version: 3.0.5Flags: cbridgha: review+
jsholl: review+
Target Milestone: 3.2.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch
none
updated patch
none
Patch none

Description Hari Shankar CLA 2010-07-26 13:23:51 EDT 
Build Identifier: 321

This bug is a clone of bug 320436. 

This bug introduces changes that ensure that when an external jar with a main class in its manifest is added via the deployment assembly page, 

a) it shows up properly under the utility jars node in enterprise explorer, and
b) deploys as a utility jar (instead of a module) onto the server.

Reproducible: Always
Comment 1 Hari Shankar CLA 2010-07-26 13:25:20 EDT 
Created attachment 175244 [details]
Patch

Patch Attached.
Comment 2 Hari Shankar CLA 2010-07-28 15:15:38 EDT 
Created attachment 175437 [details]
updated patch

Updated the patch to handle case where the earLibDir variable is null in JavaEEArchiveUtilities.
Comment 3 Chuck Bridgham CLA 2010-08-04 17:03:50 EDT 
approved
Comment 4 Jason Sholl CLA 2010-08-05 10:29:14 EDT 
Hari, please use the EARUtilities.getEARLibDir() method for 3.2.2 instead of creating a new utility for this.
Comment 5 Hari Shankar CLA 2010-08-05 14:47:21 EDT 
Created attachment 175969 [details]
Patch

Updated with Jason's comment.
Comment 6 Hari Shankar CLA 2010-08-10 12:33:18 EDT 
Jason, could you please review this and release? Thanks.
Comment 7 Jason Sholl CLA 2010-08-10 14:09:36 EDT 
code checked into head for wtp 3.2.2