Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320923

Summary: authentication failure message does not appear
Product: z_Archived Reporter: Charley Wang <charley.wang>
Component: MylynAssignee: Frank Becker <eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: robert.elves, steffen.pingel
Version: 3.4   
Target Milestone: 3.4.2   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 208839    
Attachments:
Description Flags
commited patch
none
mylyn/context/zip none

Description Charley Wang CLA 2010-07-26 11:54:21 EDT
Steps to reproduce:
1. Create a repository that requires passwords for task submission
2. Select a username
3. Enter the wrong password for that username. Hit Finish, do not attempt a query.
4. Attempt to submit a new task


Result:
Repository properties page pops up at once, no visible prompt to change password/username. If I continue to hit Finish, eventually my account will get locked out due to too many login attempts -- this message will be logged in the Task as a "Submit failed: " message.


Expected result:
It would be nice to see the error message reflect the server response, which warns that the password is incorrect. With the present setup it is easy to accidentally get locked out of a Bugzilla account. Some brief experimentation shows that the incorrect password warning does not appear for most actions. 

Because the authentication failure is potentially the most workflow disruptive (resulting in various sanctions depending on the installation), perhaps that error message message can be made to supercede all others when an action fails?
Comment 1 Steffen Pingel CLA 2010-07-27 13:14:44 EDT
Agreed, this should be considered as part of bug 320923.
Comment 2 Frank Becker CLA 2010-08-29 13:33:26 EDT
Created attachment 177689 [details]
commited patch
Comment 3 Frank Becker CLA 2010-08-29 13:33:28 EDT
Created attachment 177690 [details]
mylyn/context/zip
Comment 4 Frank Becker CLA 2010-08-29 13:36:06 EDT
Should we do an backport for this?
Comment 5 Steffen Pingel CLA 2010-08-30 13:49:19 EDT
Looks fairly straight forward. Rob, can you please confirm that it's okay to apply the patch to the 3.4.x branch?
Comment 6 Steffen Pingel CLA 2010-09-01 17:34:46 EDT
I have applied the patch to the e_3_6_m_3_4_x branch.