| Summary: | [Model Explorer] Newly created objects (via "New Child" menu) shall get focus and be in rename mode | ||
|---|---|---|---|
| Product: | [Modeling] Papyrus | Reporter: | Yann Tanguy <yann.tanguy> |
| Component: | Views | Assignee: | Gabriel Pascual <gabriel.pascual> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | cletavernier, mciobanu, papyrus-bugs, Patrick.Tessier, ronan.barrett, rschnekenburger |
| Version: | 1.0.1 | ||
| Target Milestone: | SR2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | 335835 | ||
| Bug Blocks: | |||
|
Description
Yann Tanguy
In r3629 : - Select newly created element (after "Create child" command). Uses ModelExplorerView#revealSemanticElement() which does not work correctly for now (it was in 0.7.X, but it seem we have a regression in trunk). this bug is not valid anymore in the version 0.8.X (In reply to comment #2) > this bug is not valid anymore in the version 0.8.X The bug related to selection and focus on the new element is fixed. But the auto "rename mode" on newly created element still need to be implemented. In 0.10.0, the newly created element is not selected. It is not in edit mode either. I agree that this is an important usability issue. I'm currently working on this one. Current state: - Improve the "select & reveal" method in the ModelExplorer, to ensure that it is properly refreshed before trying to select new element (To avoid the sequence Element created -> Try to select -> Element displayed: the element cannot be selected because it is not displayed yet). This doesn't prevent the asynchronous/lazy refresh of the ModelExplorer and doesn't impact performances - Call "Select & reveal" after the creation of elements from the New Child menu The newly created element is not in "rename" mode, because the rename action from the ModelExplorer is a blocking dialog, which may "Interrupt the flow". However, the element is selected in the Properties view and may be renamed from there. I will push the branch after M6, as this required non-trivial changes on the ModelExplorer implementation. Implemented in commit cf1d28e, branch bugs/320908-selectNewChild Fixed in 8ac0c59 on master, except for this part:
> The newly created element is not in "rename" mode, because the rename action from the ModelExplorer is a blocking dialog, which may "Interrupt the flow". However, the element is selected in the Properties view and may be renamed from there.
which will not be implemented
*** Bug 419461 has been marked as a duplicate of this bug. *** Has there been a regression here? This stopped working a while back. On today's build on Luna (on Ubuntu 14.0.4) it certainly does not work. The fix has been overridden when the new "New child" menu implementation has been pushed in Luna. It hasn't been restored since then Fix backported on Maintenance/Luna: https://git.eclipse.org/r/#/c/41827/ I close the task |