Bugzilla – Full Text Bug Listing
| Summary: | DiagramDocumentEditor limits status line message to single element selection | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] GMF-Runtime | Reporter: | Linda Damus <ldamus> | ||||
| Component: | General | Assignee: | Linda Damus <ldamus> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ahunter.eclipse | ||||
| Version: | 1.4.0 | ||||||
| Target Milestone: | 1.4.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Hi Linda, I do not think this is a breaking change, the label provider should be able to handle any object it gets. I agree, it should. My concern is for those clients who may not have been rigorous in checking the type of the input. I was thinking we should avoid exposing the potential defect in their implementation until a major release. Perhaps that is over-protective? (In reply to comment #2) > [snip] Perhaps that is > over-protective? Yes, I think this is over protective and we can make the change. Created attachment 175310 [details]
Proposed fix.
Code reviewed by Anthony. Committed the fix. Hi Linda, I can see the change in HEAD but not R1_4_maintenance. I am going to merge the change back. Thanks Anthony! I was confused and thought HEAD was still the 1.4.x stream. |
The DiagramDocumentEditor#handleSelectionChanged method updates the status line message contribution only for the first element in the diagram selection. I would like to display a status line message that indicates the number (and possibly type) of elements in the selection, when more than one elements in selected in the diagram editor. Please consider passing the entire selection to the status line label provider, like this: protected void handleSelectionChanged() { if (isStatusLineOn() && statusLineLabelProvider != null) { IStructuredSelection selection = (IStructuredSelection) getSite(). getSelectionProvider().getSelection(); updateStatusLineMessageContribution( statusLineLabelProvider.getText(selection), statusLineLabelProvider.getImage(selection)); } }