Bugzilla – Full Text Bug Listing
| Summary: | [CSS] White background results in lost separators (non-classic themes) | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> | ||||||||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | major | ||||||||||||
| Priority: | P3 | CC: | aniefer, curtis.windatt.public, emoffatt, john.arthorne, kalyan_prasad, Lars.Vogel, markus.kell.r, Michael_Rennie, Mike_Wilson, pwebster, remy.suen, Szymon.Brandys | ||||||||||
| Version: | 4.1 | ||||||||||||
| Target Milestone: | --- | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows XP | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dani Megert
Created attachment 175218 [details]
Screenshot
I think this may be a duplicate of bug 320238? >I think this may be a duplicate of bug 320238?
Bug is very concrete about the separators inside the table of the History view. Not sure whether one fix fixes all the issues we see.
This is a critical usability issue for me. See also bug 332452 *** Bug 332452 has been marked as a duplicate of this bug. *** Dani, the "critical" importance is defined as: "crashes, loss of data, severe memory leak". Looks like this is fixed in Juno M3. Created attachment 214196 [details]
Screenshot 2
This is still as bad as in the first screenshot.
With the default themes (at least on Windows 7 and Mac), the widget background color (usually SWT.COLOR_WIDGET_BACKGROUND) and the SWT.COLOR_LIST_BACKGROUND are both plain white, which causes information loss.
The problem is solved when I switch to the Classic theme and then restart, but the defaults should not be broken.
Reopening. *** Bug 320238 has been marked as a duplicate of this bug. *** Another instance of this problem can be seen in the Breakpoints view for Java line breakpoints: When I toggle 'Conditional', the background of the whole configuration area toggles between gray and white. (In reply to comment #12) > Another instance of this problem can be seen in the Breakpoints view for Java > line breakpoints: When I toggle 'Conditional', the background of the whole > configuration area toggles between gray and white. Yup, that problem is quite interesting. I switched to the 'Classic' theme so it doesn't bother me anymore. See bug 333778 comment 2 and down for a prior mentioning of this problem. Thanks for the pointer Remy, filed bug 379022 for comment 12 and 13. *** Bug 379022 has been marked as a duplicate of this bug. *** Created attachment 216353 [details]
variables view
This is still a problem.
I makes the Expressions and Variables view look like the details just float in the bottom of the view
Created attachment 237644 [details]
Variables view in Luna M3
Is this bug already fixed or am I misunderstanding it. When I look at the variables view in latest build I see a clear grey separator between panes. When I compare this to Michael's screen shot where there is no visible separator it looks like the problem has been fixed? The general bug is not fixed, but clients are starting to hack around the problem one-by-one. E.g. in VariablesView#refreshDetailPaneContents(). Better check views that have not been hacked, like the JUnit, Type Hierarchy, or the CVS History view. In the Git History view, they added borders to work around this bug. Comment 9 and bug 340889 explain the underlying problem: E4 can't just hammer a white background color into all widgets while SWT.COLOR_WIDGET_BACKGROUND is still gray. (In reply to Markus Keller from comment #19) > Comment 9 and bug 340889 explain the underlying problem: E4 can't just > hammer a white background color into all widgets while > SWT.COLOR_WIDGET_BACKGROUND is still gray. Ok thanks that explains it. Should this bug be made a duplicate of bug 340889 then? The main description in this bug ("white background causes troubles") is pretty unclear to me. Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon. Moving target milestone to 4.9 for all bugs that are major or above. Moving target milestone to 4.11 for all bugs that are major or above. Mass change, please reset target if you still planning to fix this for 4.11. Please set the target milestone back to 4.12 if you still intend to fix this for 4.12. I think that has been fixed, please reopen if you still see this issue in the new 4.16 light theme. |