Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320832

Summary:

NPE in ElementImpl.hashCode (again)

Product:

[Eclipse Project] JDT

Reporter:

Walter Harley <eclipse>

Component:

APT

Assignee:

Generic inbox for the JDT-APT component <jdt-apt-inbox>

Status:

CLOSED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

amj87.iitr, eclipse, Olivier_Thomann, srikanth_sankaran, stephen

Version:

3.6

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

stalebug

Bug Depends on:

318134

Bug Blocks:

Attachments:

Description	Flags
Proposed patch (copied from bug 318134)	none

Description Walter Harley

2010-07-24 22:09:31 EDT

+++ This bug was initially created as a clone of Bug #318134 +++

Build Identifier: I20100608-0911

With APT enabled, methods annotated with SuppressWarnings, a generic parameter, and an unresolved inner type will cause an NPE compiler crash.

Reproducible: Always

Steps to Reproduce:
Put the following code in an APT-enabled project:

public class Foo {	
	@SuppressWarnings("unchecked")
	private <B> void bar(final Zaz.Inner<B> zaz) {
	}
}

Where Zaz is an unresolved type and you should get the following stack trace [1].

Note that changing Zaz.Inner<B> to "Zaz<B>" or "Zaz.Inner" both make the NPE go away. As does removing the SuppressWarnings, or disabling the APT processor. Or changing "Zaz" to be a resolved type (say java.util.Map or fixing the classpath error that led to Zaz being unavailable).

[1]: java.lang.NullPointerException
at org.eclipse.jdt.internal.compiler.apt.model.ElementImpl.hashCode(ElementImpl.java:110)
at java.util.HashMap.put(HashMap.java:372)
at java.util.HashSet.add(HashSet.java:200)
at org.eclipse.jdt.internal.compiler.apt.util.ManyToMany.put(ManyToMany.java:198)
at org.eclipse.jdt.internal.compiler.apt.dispatch.AnnotationDiscoveryVisitor.resolveAnnotations(AnnotationDiscoveryVisitor.java:187)
at org.eclipse.jdt.internal.compiler.apt.dispatch.AnnotationDiscoveryVisitor.visit(AnnotationDiscoveryVisitor.java:128)
at org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse(MethodDeclaration.java:230)
at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse(TypeDeclaration.java:1290)
at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse(CompilationUnitDeclaration.java:691)
at org.eclipse.jdt.internal.compiler.apt.dispatch.RoundEnvImpl.<init>(RoundEnvImpl.java:56)
at org.eclipse.jdt.internal.compiler.apt.dispatch.BaseAnnotationProcessorManager.processAnnotations(BaseAnnotationProcessorManager.java:148)
at org.eclipse.jdt.internal.apt.pluggable.core.dispatch.IdeAnnotationProcessorManager.processAnnotations(IdeAnnotationProcessorManager.java:134)
at org.eclipse.jdt.internal.compiler.Compiler.processAnnotations(Compiler.java:809)
at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:428)
at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile(AbstractImageBuilder.java:364)
at org.eclipse.jdt.internal.core.builder.BatchImageBuilder.compile(BatchImageBuilder.java:178)
at org.eclipse.jdt.internal.core.builder.AbstractImageBuilder.compile(AbstractImageBuilder.java:301)
at org.eclipse.jdt.internal.core.builder.BatchImageBuilder.build(BatchImageBuilder.java:60)
at org.eclipse.jdt.internal.core.builder.JavaBuilder.buildAll(JavaBuilder.java:254)
at org.eclipse.jdt.internal.core.builder.JavaBuilder.build(JavaBuilder.java:173)
at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:629)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:172)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:203)
at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:255)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:258)
at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:311)
at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:343)
at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:144)
at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:242)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Comment 1 Walter Harley

2010-07-24 22:10:47 EDT

Cloned so that we can do the short-term fix (null check in APT annotation discovery visitor) in 3.6.1, while we investigate a more solid fix (missing type binding in compiler) for 3.7.

Comment 2 Walter Harley

2010-07-24 22:11:49 EDT

Created attachment 175169 [details]
Proposed patch (copied from bug 318134)

Comment 3 Eclipse Genie

2020-03-13 17:18:09 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.