Bugzilla – Full Text Bug Listing
| Summary: | Minimized stacks are missing on restart | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Eric Moffatt <emoffatt> | ||||||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||||||
| Severity: | major | ||||||||||
| Priority: | P3 | CC: | bokowski, remy.suen | ||||||||
| Version: | 1.0 | ||||||||||
| Target Milestone: | 1.0 RC3 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 175156 [details]
Here's a deltas file that gives me no trim stacks...
The bug seems somewhat sporatic, I've had the test scenario work but fails often enough...
If you are in this state then unmax-ing the editor area will throw NPEs. Reset perspective seems to get you back to sanity.
Here are steps: 1. Start with a fresh workspace 2. Detach the Package Explorer 3. Minimize the Package Explorer -> goes to the trim 4. Restart -> No minimized stack for the Package Explorer anymore *** Bug 317506 has been marked as a duplicate of this bug. *** Created attachment 175219 [details]
The deltas file from a 'failing' version produced by my original steps\
(In reply to comment #4) > Created an attachment (id=175219) [details] > The deltas file from a 'failing' version produced by my original steps\ From the file, we can see that it is merely recording a direct reference to some other EMF object instead of preserving the object in its entirety... <trimBars> <reference elementId="_vvVoUJi5Ed-hoIBGGUL7JQ"/> <reference elementId="_vveyQJi5Ed-hoIBGGUL7JQ"/> </trimBars> ...like so... <trimBars> <reference e4namespace="http://www.eclipse.org/ui/2010/UIModel/application/ui/basic" type="org.eclipse.e4.ui.model.application.ui.basic.MTrimBar" unset="true" xmiId="_i0vdUJi9Ed-4eNTZLPBU-w"> <!-- ... --> </reference> </trimBars> Created attachment 175221 [details] XMLModelReconciler patch v1 The reconciler was asking trimmed windows whether their trim bars changed. If a workbench window was asked, then 'true' would be returned and the deltas would be persisted properly. If 'false' was returned, we would get the problem described in comment 5 where only an id reference was made. The reason this bug was "somewhat" reproducible is because the iteration over the trimmed windows is undefined (as it is merely a map). So sometimes you'd get the workbench window first and get 'true' and sometimes you'd get the detached window first and get 'false'. +1 from me...I haven't had any recurrences running with the patched code... +1 Fix released to CVS HEAD. Thanks for finding this bug, Eric. Verified on XP in I20100726-2152 (Using many of my old scenarios that would show this). |
Run a fresh inner (no deltas) Detach the Outline view by dragging it right maximize the editor area close restart There are no minimized stacks visible If yoiu put a breakpoint in the WBWRenderer's processContents where it's restoring the trimBars before the restart you can see that there is only the one 'top' trim bar in the model, not sure where they went...I'll attach my deltas file, to my untrained eye the minimized stacks seem to be there (i.e. if you do a find on 'left(' there is a ToolControl defined).