Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320802

Summary: ASTParser.createASTs(..) fails silently on multiple missing parameter types.
Product: [Eclipse Project] JDT Reporter: Alexander Kitaev <kitaev>
Component: CoreAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: jarthana, kitaev, Olivier_Thomann, satyam.kandula, srikanth_sankaran
Version: 3.7Flags: srikanth_sankaran: review+
Target Milestone: 3.6.1   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch (for org.eclipse.jdt.core_3.7.0.vB_03)
Olivier_Thomann: iplog+
JUnit4 test plugin project
none
Proposed fix + regression test none

Description Alexander Kitaev CLA 2010-07-24 08:56:31 EDT
Build Identifier: I20100608-0911

The following code couldn't be parsed by ASTParser.createASTs(...) with binding resolving enabled:

map = new HashMap<MissingT1, MissingT2>();

Reproducible: Always

Steps to Reproduce:
Run attached test case. I was testing it against versions A_58 and B_03 of org.eclipse.jdt.core
Comment 1 Alexander Kitaev CLA 2010-07-24 08:58:00 EDT
Created attachment 175141 [details]
patch (for org.eclipse.jdt.core_3.7.0.vB_03)
Comment 2 Alexander Kitaev CLA 2010-07-24 09:01:08 EDT
Created attachment 175142 [details]
JUnit4 test plugin project
Comment 3 Olivier Thomann CLA 2010-07-27 11:53:33 EDT
Indeed the referenceContext is reset to null once the problem is reported, we need to preserve it if we want to be able to report more than one problem.
Reviewing the patch.
Comment 4 Olivier Thomann CLA 2010-07-27 13:41:12 EDT
Srikanth, we might want to backport for 3.6.1 as we are missing the compilation unit creation.
Released for 3.7M1.
Added regression test in:
org.eclipse.jdt.core.tests.dom.ASTModelBridgeTests#test320802
Comment 5 Olivier Thomann CLA 2010-07-27 13:41:33 EDT
Created attachment 175341 [details]
Proposed fix + regression test
Comment 6 Olivier Thomann CLA 2010-07-27 13:42:01 EDT
Srikanth, please review for 3.6.1.
Comment 7 Satyam Kandula CLA 2010-08-04 02:14:15 EDT
Verified for 3.7M1 using build I20100802-1800
Comment 8 Srikanth Sankaran CLA 2010-08-04 04:21:27 EDT
Patch looks good.
Comment 9 Olivier Thomann CLA 2010-08-05 18:35:46 EDT
*** Bug 320633 has been marked as a duplicate of this bug. ***
Comment 10 Alexander Kitaev CLA 2010-08-19 16:52:38 EDT
Hello,

I didn't find the fix in v_A64_R36x of JDT. Do you still plan to include this fix into 3.6.1?

Thanks!
Comment 11 Srikanth Sankaran CLA 2010-08-19 18:26:33 EDT
(In reply to comment #10)
> Hello,
> 
> I didn't find the fix in v_A64_R36x of JDT. Do you still plan to include this
> fix into 3.6.1?

Yes, I'll release patch shortly. Thanks.
Comment 12 Srikanth Sankaran CLA 2010-08-19 18:27:29 EDT
Reopen to back port to 3.6.1
Comment 13 Jay Arthanareeswaran CLA 2010-08-20 03:18:20 EDT
Using same patch (comment #5) for R3_6_maintenance.
Comment 14 Jay Arthanareeswaran CLA 2010-08-20 03:18:47 EDT
Released in R3_6_maintenance for 3.6.1.
Comment 15 Satyam Kandula CLA 2010-08-26 07:39:23 EDT
Verified for 3.6.1 RC2 using Build id: M20100825-0800