Bugzilla – Full Text Bug Listing
| Summary: | Tabs should not have blue focus ring on Mac | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Boris Bokowski <bokowski> | ||||||
| Component: | UI | Assignee: | Bogdan Gheorghe <gheorghe> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | Mike_Wilson, pwebster, remy.suen, susan | ||||||
| Version: | unspecified | Flags: | bokowski:
review+
|
||||||
| Target Milestone: | 1.0 RC3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Boris Bokowski
Created attachment 175112 [details]
Patch for CSS
Paul, can you please commit this (org.eclipse.platform)? Thanks. Instead of the focus rectangle (on Windows), I get an underline now. I'm not sure which is uglier. In any case, this is more of a renderer/part activation problem than a CSS issue. Agreed. We talked about this today and said that the activation issue will have to be solved in 4.1. The main goal was to make this not look ugly on the Mac. We might just go back to what we had for Windows, so that this change only applies to the Mac. Bogdan and I put "simple: false" in all the stylesheets for consistency, but we should look at this one more time on Monday. (In reply to comment #3) > Instead of the focus rectangle (on Windows), I get an underline now. I'm not > sure which is uglier. In any case, this is more of a renderer/part activation > problem than a CSS issue. I think the focus ring is well-known on windows and esp. in light of the fact that it flashes on/off as the editor grabs focus, I find that the flashing underline looks like cheese, whereas I understand that focus ring. I think we should set simple back to true for windows at least. The question is what do GTK folks think? (In reply to comment #5) > I think we should set simple back to true for windows at least. > The question is what do GTK folks think? I think GTK+ needs to go back to simple too. The line doesn't really tell me anything. Susan, are you going to make the changes? Created attachment 175277 [details]
GTK focus line
The focus line has always been around in 3.x (as all CTabFolders are not "simple" if they have the swoosh appearance). The difference is when you click on a tab in 3.x, the editor takes focus right away. If you hit Ctrl+Shift+Tab you will get the line in GTK as shown in the pic.
(In reply to comment #8) > Created an attachment (id=175277) [details] > GTK focus line > > The focus line has always been around in 3.x (as all CTabFolders are not > "simple" if they have the swoosh appearance). The difference is when you click > on a tab in 3.x, the editor takes focus right away. If you hit Ctrl+Shift+Tab > you will get the line in GTK as shown in the pic. sure enough. And on windows too. So the fact that you get the momentary flash is probably bringing it more to our attention... I'm inclined to leave as is on GTK and Mac, change on Windows? I don't feel strongly. committed changes to HEAD, consensus (or more honestly, no resistance, or perhaps apathy)... on IRC to change on windows, but not on GTK. I think we'll get questions about the flash irrelevant to the focus emphasis used. |