Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320710

Summary:	Generated PaletteFactory create PaletteSeparator with empty id
Product:	[Modeling] GMF-Tooling	Reporter:	Baptiste Mesta <baptiste.mesta>
Component:	Core	Assignee:	Project Inbox <gmp.gmf-tooling-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	mistria
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Baptiste Mesta

2010-07-23 07:57:53 EDT

Build Identifier: 20100617-1415

Even if we set the Label of the palette separator in the gmftool file, all separators have empty id.
The gmfgen does not contains any id for this item.
In consequence we can't save the hide/show state of the separators (exeptions occurs since the id is empty)
this can be fixed by generating simple ids here
/org.eclipse.gmf.codegen/templates/xpt/editor/palette/PaletteFactory.xpt
«DEFINE addEntry(varName : String) FOR gmfgen::Separator-»
«varName».add(new org.eclipse.gef.palette.PaletteSeparator());
«ENDDEFINE»

Reproducible: Always

Steps to Reproduce:
1.add separator in the palette
2.in the generated palette go in the customize dialog and hide a separator
3.click on ok -> an exeption is thrown
-> reopening the diagram show the separators

Comment 1 Mickael Istria

2011-08-08 12:28:46 EDT

Can you please provide your suggested changes as a patch?