Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320584

Summary:

win7 tab font is wrong

Product:

[Eclipse Project] e4

Reporter:

Susan McCourt <susan>

Component:

Assignee:

Project Inbox <e4.ui-inbox>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

bokowski, gheorghe, remy.suen, s.muecke

Version:

1.0

Target Milestone:

1.0 RC3

Hardware:

OS:

Windows 7

Whiteboard:

Bug Depends on:

Bug Blocks:

314157

Attachments:

Description	Flags
screenshot	none
comparison screenshots...	none

Description Susan McCourt

2010-07-22 00:41:28 EDT

+++ This bug was initially created as a clone of Bug #314157 +++

Cloned but to pull out the issue we are fixing for 4.0

The Win7 default tab font is not Segoe UI.  The CSS code seems to be choosing any random font that meets the specs defined in the stylesheet rather than force the default font.

The workaround for 4.0 is to specify Segoe UI as the font face for the win7 theme.

Note this might cause problems with the win7 theme on non-win7 platforms, but our desire is to make "win7 on win7" look right.

Comment 1 Susan McCourt

2010-07-22 00:43:58 EDT

fixed in HEAD >20100721.
The patch is in the original bug (bug 314157) and since Boris did it, and I reviewed it, and we both said +1 for RC3, I'm releasing it.

Comment 2 Susan McCourt

2010-07-22 12:14:51 EDT

Reopening.  The font looks good, but now we have a new white line running across the bottom of the selected tab stack above the gray key line...

Comment 3 Susan McCourt

2010-07-22 12:15:35 EDT

Created attachment 174997 [details]
screenshot

didn't notice this last night but it jumped out at me today

Comment 4 Susan McCourt

2010-07-22 16:15:22 EDT

*** Bug 320660 has been marked as a duplicate of this bug. ***

Comment 5 Susan McCourt

2010-07-22 16:15:59 EDT

From duplicate bug:

Interestingly, this only happens with certain font sizes:
   9 - okay
  10 - BUG
  11 - okay
  12 - BUG
  13 - okay
  14 - okay
  15 - BUG

Comment 6 Bogdan Gheorghe

2010-07-22 18:15:20 EDT

Took a look at this - it has to do with the gradient calculations for the unselected tabs (ie. the blue), certain sizes of fonts result in the white fill of the body starting a pixel too early. (This is why you weren't seeing it before hammering in the Segoe UI font and why I can't see it on XP).

Not sure that a "safe" fix is a possibility at this point - maybe just down or up a size in the CSS?

Comment 7 Susan McCourt

2010-07-22 19:13:40 EDT

Created attachment 175025 [details]
comparison screenshots...

Bogdan and I looked at Segoe UI 9, 10, 11.
11 seems way too big.
9 is unfortunately small.
10 has the white line.

If I have to pick, I guess I'd pick 9.
Stefan, Boris, others...what do you think?  

This screenshot shows all three choices.

Comment 8 Remy Suen

2010-07-22 19:19:13 EDT

11's a bit much, please go with 9. If the design was intended to be 10, then we can investigate a fix after 4.0 goes GA. If people don't like it, they can make it 10 or 11 or whatever.

Comment 9 Boris Bokowski

2010-07-22 19:29:30 EDT

(In reply to comment #7)
> If I have to pick, I guess I'd pick 9.

Me too.

Comment 10 Susan McCourt

2010-07-22 21:26:01 EDT

consensus is 9 (including Linda the designer).
committed >20100722.

Comment 11 Susan McCourt

2010-07-27 13:59:01 EDT

verified on win7, I20100726-2152
We have Segoe UI 9 as expected.
bug 314157 tracks the fact that we would have liked to use a larger font.