Bug 320571

Description Navid Mehregani 2010-07-21 19:13:28 EDT

Build Identifier: 

None of the structures under AbstractArtifact.java are protected against concurrent access.  Under ArtifactRenameRequest.java the following code in updateReferences method modifies a Collection while iterating over it.  This obviously causes a ConcurrentModificationException, which in turn causes the EMF transaction to fail.  Once the transaction fails, EMF tries to rollback the transaction by recovering the old name, hence the renaming is never successful. 

Note that this only happens with contained artifacts and JRE doesn't always guarantee ConcurrentModificationException to be thrown.

ArtifactRenameRequest#updateReferences():

// take care of contained artifacts same way
// This is looking DOWNWARDS
Collection<IModelComponent> contains =  artifact						.getContainedModelComponents();
boolean containsChanged = false;
for (IModelComponent cont : contains) {
   if (cont instanceof AbstractArtifact) {
	AbstractArtifact containedArt = (AbstractArtifact) cont;
	if (containedArt.getFullyQualifiedName().equals(oldFQN)							|| containedArt.getFullyQualifiedName().equals(									newName)) {
							   aArtifact.removeContainedModelComponent(cont);
aArtifact							.addContainedModelComponent(referencedArtifact);
	needSave = false;
    }
  }
}


Reproducible: Always

Steps to Reproduce:
1. Create a new class diagram
2. Create two entities with an association between them
3. Double click on the association
4. Rename the association in the edit dialog that pops up and click on OK.

If AbstractArtifact is in fact accessed on multiple threads, then we need to protect this class under concurrent access.  Otherwise, we can fix the code snippet that I've indicated under Details section.