Bugzilla – Full Text Bug Listing
| Summary: | [CSS] Win7 Stylesheet not picked up | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Bogdan Gheorghe <gheorghe> | ||||||||
| Component: | UI | Assignee: | Bogdan Gheorghe <gheorghe> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | bokowski, remy.suen, susan | ||||||||
| Version: | unspecified | Flags: | bokowski:
review+
susan: review+ |
||||||||
| Target Milestone: | 1.0 RC3 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Bogdan Gheorghe
*** Bug 319917 has been marked as a duplicate of this bug. *** Created attachment 174917 [details]
Patch
Patch adds an os.version field to the extension point that can be used to differentiate Win versions.
+1 for fixing this for RC3, but I haven't tested the fix. +1 on the patch. It may be "different" from other eclipse extension points that you can now define themes with the same ids. Usually aren't configuration element ids assumed to be unique? However, I could also argue this as a feature, that having one semantic theme (say, super-duper-gradients) that is further specialized by platform might make more sense than the client having to make the distinction. In the same way that you can contribute different handlers to the same command id. Although that makes me wonder if we should define themes and then define stylesheets as another element that satisfies a theme (like commands and handlers). I think it's worth looking further into the shape of this extension point later. But this is not something to decide now. I tested the patch. Before the patch: a new workbench opens in the WinXP Blue theme, even though I'm running Win7. After the patch: a new workbench opens in the Win7 theme. (In reply to comment #4) > I think it's worth looking further into the shape of this extension point > later. But this is not something to decide now. > Opened bug 320563 to capture the issues I see. committed to HEAD (Bogdan doesn't have org.eclipse.platform commit rights). (In reply to comment #6) > committed to HEAD (Bogdan doesn't have org.eclipse.platform commit rights). With the latest from HEAD (unless I forgot to take something), and a fresh workspace, I still get Windows XP grey even though I am running on Windows 7. reopening I tried it again with the latest from HEAD (just synched) and with a fresh workspace on Win7, I *do* get the right theme. Hmmmm.... I tried some additional experiments, like setting the theme to something else (classic) and then restarting the launch. I see Classic. Then I restart the launch and clear the workspace. I see Win7. I couldn't get into a state where it didn't pick up Win7 when not specified. Created attachment 175081 [details]
Patch
Looks like the difference in behavior is caused by whatever VM you are running. J9 is more verbose in its os.version output. Here is a patch that will just look for the OS version number.
Can we do String.contains instead, to keep the change simple? Created attachment 175113 [details]
Take 3
Patch applied to HEAD. Boris, can you verify this one since it worked for me before that last patch went in? Yes will do, after lunch. I think I've tried it with the build that had the fix, but will verify again. Verified using I20100726-2152 on Windows 7. |