Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320436

Summary:

jar's placed in Java EE 5 Ear's lib directory should never be considered "modules"

Product:

[WebTools] WTP Java EE Tools

Reporter:

Hari Shankar <hshanka>

Component:

jst.j2ee

Assignee:

Hari Shankar <hshanka>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

ccc, jsholl

Version:

unspecified

Flags:

jsholl: review+
cbridgha: review+

Target Milestone:

3.0.5 P

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

326015

Attachments:

Description	Flags
patch	none
updated patch	none
updated patch	ccc: iplog+

Description Hari Shankar

2010-07-20 15:27:19 EDT

Build Identifier: 305P

When a jar dependency is added to the EAR in the Java EE Module Dependencies
page, a module entry is created in the application.xml, in addition to an entry
in the .component file. The entry in the application.xml should not be made if
the 'In Lib Dir' checkbox is checked.

This bug enhances bug 300098 with additional scenarios. The earlier bug covered fixing the module entry made in the application.xml. This bug covers navigator surfacing, refreshing and showing/hiding the jar in the 'Add/Remove Projects' dialog in the server view.

Reproducible: Always

Comment 1 Hari Shankar

2010-07-20 15:28:45 EDT

Created attachment 174783 [details]
patch

Comment 2 Hari Shankar

2010-07-23 12:34:07 EDT

Created attachment 175083 [details]
updated patch

Updated the patch to remove some cache optimizations that might have caused potential issues in future.

Comment 3 Chuck Bridgham

2010-07-26 13:52:50 EDT

approved

Comment 4 Carl Anderson

2010-07-26 18:16:48 EDT

The "updated patch" causes 54 JUnit failures in the org.eclipse.jst.server.core.tests.AllTests suite.  As such, I am reverting the code changes I committed for it in the R3_0_5_patches stream.

Comment 5 Hari Shankar

2010-07-28 14:53:08 EDT

Created attachment 175435 [details]
updated patch

In the previous patch, the value of JavaEEArchiveUtilities.getEARLibDir was not being checked for a null case, resulting in an incorrect value for the inLibDir variable, causing the server tools junits to fail.

Updated the patch, and ran all the server tooling and java ee tooling junits successfully.

Comment 6 Carl Anderson

2010-08-05 13:31:26 EDT

Committed to R3_0_5_patches

Comment 7 Carl Anderson

2010-08-05 13:32:59 EDT

Committed to R3_0_5_patches