Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320402

Summary:	Mylyn Reports a Permission Denied Error, but uploads the attachment when iplog/review flag is set by a non-committer.
Product:	z_Archived	Reporter:	Meisam <meisam.fathi>
Component:	Mylyn	Assignee:	Project Inbox <mylyn-triaged>
Status:	CLOSED MOVED	QA Contact:
Severity:	normal
Priority:	P3	CC:	eclipse, robert.elves
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:
Bug Blocks:	266422

Description Meisam

2010-07-20 10:54:49 EDT

I was bitten by this and attached the same patch three times to a bug report (https://bugs.eclipse.org/bugs/show_bug.cgi?id=320187)

Scenario:
John is not an authorized committer but he occasionally contributes patches via Mylyn and Bugzilla Connector to dev.eclipse.org. He opens a bug report. On the "Add Attachment" wizard he selects a patch and changes the value of iplog/review flag. When he clicks on the "Finish" button, he gets an error message indicating that he is not permitted to change the iplog/review flag. The "Add Attachment" wizard remains open. He navigates his system browser to the bug report web page on bugs.elipse.org and sees that the patch is successfully attached to the bug report. 

Expected behavior:
when he gets an error message, he doesn't expect the patch to be attached to the bug report.
 or alternatively 
He expects the dialog to be closed, after getting an error message like "The path was attached successfully, but the iplog/review flags was not changed."

Comment 1 Steffen Pingel

2010-07-27 17:09:24 EDT

Agreed, this should be a warning of some sort but probably not an error if the attachment was successfully uploaded. Rob, Frank, please consider fixing this.

Comment 2 Frank Becker

2010-08-30 14:43:01 EDT

I try to reproduce this by setup of my own bugzilla (version from head) and can not reproduce this with the latest Mylyn version.

I get an error "Bugzilla ? Flag Modification Denied" without an submit of the attachment.

I can try this with Bugzilla 3.4.8. 

I must install older versions to test this with 3.4.4 so can someone this with the latest Mylyn biuld?

Comment 3 Steffen Pingel

2010-08-30 14:53:05 EDT

I don't think this will depend on the Bugzilla or Mylyn version but on the permission setup in Bugzilla. I would not bother testing this with older Bugzilla versions since we only support the latest maintenance release of any stream.

Comment 4 Frank Becker

2010-08-30 16:20:56 EDT

(In reply to comment #3)
> I don't think this will depend on the Bugzilla or Mylyn version but on the
> permission setup in Bugzilla. I would not bother testing this with older
> Bugzilla versions since we only support the latest maintenance release of any
> stream.

OK, but I have set up my Bugzilla installation with a flag that has grant permission of editkeywords and can not reproduce this with an user that has not the permission.

Comment 5 Steffen Pingel

2010-08-30 16:35:13 EDT

Hmm, is that the same as the Grant/Request Groups for flags, e.g. http://mylyn.eclipse.org/bugs36/editflagtypes.cgi?action=edit&id=1 ?  I would suspect that this is related to that.

Comment 6 Frank Becker

2010-08-30 23:06:32 EDT

(In reply to comment #5)
> Hmm, is that the same as the Grant/Request Groups for flags, e.g.
> http://mylyn.eclipse.org/bugs36/editflagtypes.cgi?action=edit&id=1 ?  I would
> suspect that this is related to that.

Yes the Grant Group and the Request Group are the two places that I changed.

Sorry, I did not know what group is set in bugs.eclipse.org so I use the editkeywords group for my tests.

Comment 7 Eclipse Webmaster

2022-11-15 11:45:08 EST

Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn