Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320382

Summary: virgoising dm-server "slices" to virgo "snaps"
Product: [RT] Virgo Reporter: Florian Waibel <fwaibel>
Component: unknownAssignee: Glyn Normington <glyn.normington>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: glyn.normington, jkrause
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 320387    
Attachments:
Description Flags
Adapted virgoise.sh script for slices/snaps glyn.normington: iplog+

Description Florian Waibel CLA 2010-07-20 08:30:55 EDT 
Build Identifier: 

from http://dev.eclipse.org/mhonarc/lists/virgo-dev/msg00076.html

I've checked in snaps to Eclipse git. See [1] for the location.

The only changes I've made compared to the slices prototype is to uniformly rename "slices" to "snaps" (including the singular and other capitalisations), to re-package the code to org.eclipse.virgo packages, and to get this building cleanly with Virgo build. It still has dm Server pre-reqs and needs "virgoising" (the virgoise.sh shell script in the web server repo provides a good starting point).

If anyone would care to provide a patch to get this working with Virgo, please be my guest.

Glyn

[1] http://wiki.eclipse.org/Virgo/Source#Virgo_git_Repositories


Reproducible: Always
Comment 1 Florian Waibel CLA 2010-07-20 08:33:12 EDT 
Created attachment 174738 [details]
Adapted virgoise.sh script for slices/snaps
Comment 2 Glyn Normington CLA 2010-07-20 08:47:28 EDT 
Hi Florian

Thanks for raising this bug.

The IP side might seem trivial from a technical perspective, but I want to avoid problems later as this does constitute a contribution to Virgo.

So I think the cleanest solution would be for you to attach the modified virgoise.sh and then confirm that you wrote 100% of the changes to that script and that you have the right to contribute those changes to Eclipse.

Note to lawyers: virgoise.sh is a script we use for renaming dm Server package names etc. to corresponding Virgo package names etc. Florian has modified the script to deal with the Virgo snaps component.

I can then get on and integrate your patch, which looks good on the face of it.

Regards,
Glyn
Comment 3 Glyn Normington CLA 2010-07-20 08:51:13 EDT 
(In reply to comment #2)

Hi Florian

I just noticed you included the modified script in the attachment, so please just provide the necessary confirmations.

Glyn
Comment 4 Florian Waibel CLA 2010-07-20 11:10:48 EDT 
I confirm that i have written 100% of the attached virgoise.sh patch and that i'm allowed to contribute the patch to eclipse.org.
Comment 5 Glyn Normington CLA 2010-07-20 11:14:51 EDT 
Code committed to dfdc5db78de789d98abe613ad56f3b4756ea23cb.

Thanks for your contribution!