Bug 320352

Comment 1 Holger Staudacher 2010-07-20 04:02:36 EDT

Created attachment 174704 [details]
Screenshot 1

Comment 2 Holger Staudacher 2010-07-20 04:02:56 EDT

Created attachment 174705 [details]
Screenshot 2

Comment 3 Holger Staudacher 2010-07-20 04:03:19 EDT

Created attachment 174706 [details]
Screenshot 3

Comment 4 Mathias Kinzler 2010-07-22 07:19:11 EDT

Ok, I think it's a good idea to make the toolbar items into buttons. I have a pending change for these UIs anyway (since addition of push URLs is optional if a fetch URL is already defined), and I'll work this into the fix.
Of course in the longer run, what we need is a possibility to display context-sensitive help for supporting the end user...

Comment 5 Mathias Kinzler 2010-07-26 05:29:08 EDT

The suggested change to use buttons instead of toolbar items is part of Gerrit change
http://egit.eclipse.org/r/#change,1007

Comment 6 Benjamin Muskalla 2010-08-04 15:20:51 EDT

Created attachment 175878 [details]
mockup of new dialog

I think the first step to simplify the dialog is to squash all neccessary things into one page so you get an overview what you can do here. In addition, I think specifing multiple push urls in this wizard is overkill as I clicked "Add remote" and not "remotes" ;)

Comment 7 Mathias Kinzler 2010-08-05 04:05:11 EDT

(In reply to comment #6)
> Created an attachment (id=175878) [details]
> mockup of new dialog
> 
> I think the first step to simplify the dialog is to squash all neccessary
> things into one page so you get an overview what you can do here. In addition,
> I think specifing multiple push urls in this wizard is overkill as I clicked
> "Add remote" and not "remotes" ;)

Hi Benny,
offering multiple push urls is not overkill, it is required for being compatible with other Git versions when it comes to the configuration, so we need to offer it even though it might not be a frequent use case.
Still I like the idea of putting it all together like in your mockup (except that the push url field would have to be a table).
Before going in this direction, however, we should understand how to handle the specifications for push and fetch. Of course we could add some buttons next to the corresponding url field/table saying something like "Configure", but this would be quite a departure from the wizard paradigm in which the user is guided through a sequential list of screens so that they know what they have to do in order to complete the task. I'm afraid that offering some buttons here and there would be too confusing to the end user, since they wouldn't know what is finished and what not, and this was the reason for the admittedly cumbersome sequence of screens in the current wizard. Perhaps the solution is to offer the specification configuration once or twice upon "Next", depending on whether push and fetch URI(s) have been selected; of course this might also be confusing, because the (almost) same screen appears twice...

Comment 8 Mathias Kinzler 2011-03-30 07:00:32 EDT

Change http://egit.eclipse.org/r/#change,2898 does away with the previous admittedly complex wizard.