Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320344

Summary: Drag and drop of a part hides one side of a sash
Product: [Eclipse Project] e4 Reporter: Stefan Mücke <s.muecke>
Component: UIAssignee: Eric Moffatt <emoffatt>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, Lars.Vogel
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Patch that inhibits self-splitting none

Description Stefan Mücke CLA 2010-07-19 20:27:53 EDT 
1. Open a clean e4 workspace
2. Open an untitled text file
3. Move the Problems view into editor area, above 'Untitled 1'
   (so that the editor area is split) 
4. Drag the Problems view on the upper half of the 'Untitled 1' editor
   (this actually performs a drop operation but results in the same layout)
5. Repeat step 4 _five_ times
   Result: The sash ratio is not longer 0.5 but perhaps 0.7
6. Repeat step 4 again
   Result: The upper sash half, i.e. the 'Untitled 1' editor is gone
7. Close the Problems view
   Result: SWTException. Editor area is killed.
Comment 1 Stefan Mücke CLA 2010-07-19 20:30:17 EDT 
This works also the other way around, by dropping the problems views repeatedly on the lower half of the 'Untitled 1' editor.
Comment 2 Stefan Mücke CLA 2010-07-19 20:35:46 EDT 
There are even more ways to reproduce this error. Either direction works, and also dropping alternately on opposite halves (right <--> left, bottom <--> top).
Comment 3 Boris Bokowski CLA 2010-07-21 13:11:14 EDT 
We're likely creating more and more empty part sash containers over time.
Comment 4 Eric Moffatt CLA 2010-07-21 15:33:17 EDT 
Boris, it's at this point just a conjecture that we're creating many stacks. Can you verify this (the live model editor should show this nicely..;-) ?
Comment 5 Eric Moffatt CLA 2010-07-24 17:36:58 EDT 
Created attachment 175166 [details]
Patch that inhibits self-splitting


This will at least cut down on the ways that this defect can be manifested...
Comment 6 Boris Bokowski CLA 2010-07-24 17:42:09 EDT 
+1, makes sense
Comment 7 Eric Moffatt CLA 2010-07-24 17:52:22 EDT 
Committed in >20100725. Applied the patch.

I'll leave this defect open though to track the hall of mirrors issues...
Comment 8 Boris Bokowski CLA 2010-07-24 18:08:41 EDT 
(In reply to comment #7)
> Committed in >20100725. Applied the patch.
> 
> I'll leave this defect open though to track the hall of mirrors issues...

Could you please open a new bug for the remaining issues? I am marking this one as fixed for 1.0 RC3 so that it shows up properly in the build submission, and in later bug queries.
Comment 9 Eric Moffatt CLA 2010-08-27 10:26:57 EDT 
I've opened bug 323832 to track the 'hall of mirrors' issues.