Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320341

Summary: Drag and drop rectangles: DnDManager should use stippled tracker
Product: [Eclipse Project] e4 Reporter: Stefan Mücke <s.muecke>
Component: UIAssignee: Susan McCourt <susan>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, emoffatt, susan
Version: unspecifiedFlags: susan: review? (emoffatt)
bokowski: review+
Target Milestone: 1.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
patch none

Description Stefan Mücke CLA 2010-07-19 19:52:24 EDT 
I think the line width of the DND preview rectangles is too thin.

e4 should use the same preview rectangles as 3.x by setting the 'stippled' option on the tracker:

tracker.setStippled(true);

BTW, I think the DnD... classes in e4 should be renamed DND... to be consistent with SWT.
Comment 1 Boris Bokowski CLA 2010-07-20 17:58:20 EDT 
I have no opinion on this one. It'd be pretty safe if we did it, and 3.6 uses setStippled(true). Susan?
Comment 2 Susan McCourt CLA 2010-07-20 19:11:47 EDT 
I see no reason to change from 3.6.  Users are used to the stippled look and this seems a safe change.
Comment 3 Susan McCourt CLA 2010-07-20 19:12:25 EDT 
Created attachment 174804 [details]
patch

patch that sets the stippling.
Comment 4 Susan McCourt CLA 2010-07-20 19:12:57 EDT 
Eric, can you review?
Comment 5 Susan McCourt CLA 2010-07-20 19:13:55 EDT 
Boris, OK for RC3?

Stefan, can you open a separate bug for the naming inconsistency?
I'm sure we'll do an API cleanup sweep in 4.1 and we could address this then.
Comment 6 Boris Bokowski CLA 2010-07-20 20:25:53 EDT 
sure
Comment 7 Stefan Mücke CLA 2010-07-21 01:10:03 EDT 
(In reply to comment #5)
> Stefan, can you open a separate bug for the naming inconsistency?
> I'm sure we'll do an API cleanup sweep in 4.1 and we could address this then.

Opened bug 320460. Target milestone needs to be set to 4.1.
Comment 8 Susan McCourt CLA 2010-07-22 11:40:47 EDT 
these changes went in with bug 302758.
stippling is present in  I20100721-2056
Comment 9 Susan McCourt CLA 2010-07-27 13:51:09 EDT 
verified (again) on Win7, Build id: I20100726-2152
Comment 10 Eric Moffatt CLA 2010-07-27 14:57:20 EDT 
Verified on XP in I20100726-2152.