Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320239

Summary: View Toolbar Icons are clipped
Product: [Eclipse Project] e4 Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Bogdan Gheorghe <gheorghe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bokowski, gheorghe, john.arthorne, pwebster
Version: 0.9Flags: bokowski: review+
Target Milestone: 1.0 RC3   
Hardware: PC   
OS: Linux-GTK   
Whiteboard:
Attachments:
Description Flags
Screenshot
none
Patch
none
Update to patch none

Description Thomas Schindl CLA 2010-07-19 06:20:39 EDT
Created attachment 174603 [details]
Screenshot

I only see this issue on GTK.
Comment 1 Thomas Schindl CLA 2010-07-19 06:21:21 EDT
Paul is this only on my Ubuntu Box or a do you also see this?
Comment 2 Thomas Schindl CLA 2010-07-19 06:34:18 EDT
if it turns out to be a common GTK problem i think we should fix it before we ship because it makes 4.0 look strange.
Comment 3 Paul Webster CLA 2010-07-19 09:15:49 EDT
I don't see them clipped, just bug 319780
PW
Comment 4 Thomas Schindl CLA 2010-07-20 02:16:01 EDT
This happens for me on Ubuntu
Comment 5 Bogdan Gheorghe CLA 2010-07-20 11:13:56 EDT
The differences you guys see comes from the default themes used on GTK - RHEL5 uses Clearlooks while the latest Ubuntu uses the Ambiance theme. The Ambiance theme adds a bunch of padding to tool items, hence the clipping.

We need to figure out and set the tab height before we set a top right control (3.6 did this which is why it doesn't have the same problem). I will attach a patch.
Comment 6 Boris Bokowski CLA 2010-07-20 16:44:40 EDT
We've listed this as a P2 on our RC3 list.
Comment 7 Bogdan Gheorghe CLA 2010-07-22 14:50:46 EDT
Created attachment 175011 [details]
Patch
Comment 8 Bogdan Gheorghe CLA 2010-07-22 16:08:29 EDT
Created attachment 175020 [details]
Update to patch
Comment 9 Bogdan Gheorghe CLA 2010-07-22 16:10:02 EDT
This patch updates the tab height based on the size of the top right control being set in the CTabFolder as well as adding some missing clean up code for disposing of the background image/color when a new top right control is set.
Comment 10 Boris Bokowski CLA 2010-07-22 17:23:39 EDT
+1
Comment 11 Bogdan Gheorghe CLA 2010-07-23 11:43:09 EDT
Fixed in HEAD > 20100722