| Summary: | View Toolbar Icons are clipped | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Thomas Schindl <tom.schindl> | ||||||||
| Component: | UI | Assignee: | Bogdan Gheorghe <gheorghe> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | bokowski, gheorghe, john.arthorne, pwebster | ||||||||
| Version: | 0.9 | Flags: | bokowski:
review+
|
||||||||
| Target Milestone: | 1.0 RC3 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux-GTK | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Paul is this only on my Ubuntu Box or a do you also see this? if it turns out to be a common GTK problem i think we should fix it before we ship because it makes 4.0 look strange. I don't see them clipped, just bug 319780 PW This happens for me on Ubuntu The differences you guys see comes from the default themes used on GTK - RHEL5 uses Clearlooks while the latest Ubuntu uses the Ambiance theme. The Ambiance theme adds a bunch of padding to tool items, hence the clipping. We need to figure out and set the tab height before we set a top right control (3.6 did this which is why it doesn't have the same problem). I will attach a patch. We've listed this as a P2 on our RC3 list. Created attachment 175011 [details]
Patch
Created attachment 175020 [details]
Update to patch
This patch updates the tab height based on the size of the top right control being set in the CTabFolder as well as adding some missing clean up code for disposing of the background image/color when a new top right control is set. +1 Fixed in HEAD > 20100722 |
Created attachment 174603 [details] Screenshot I only see this issue on GTK.