Bugzilla – Full Text Bug Listing
| Summary: | Support MSbuild error pattern in VC error parser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc-André Laperle <malaperle> | ||||
| Component: | cdt-build | Assignee: | Marc-André Laperle <malaperle> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Marc-André Laperle <malaperle> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | nikitin.alexander, Viktor.Braun | ||||
| Version: | 7.0 | ||||||
| Target Milestone: | 10.3.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows All | ||||||
| See Also: |
https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/178792 https://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=8b3998eb4175a739277f3886e8f041f17378b59a |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
A small patch, huh? I have some comments: - VCerrorParser should be converted to RegexErrorParser style. That is not hard to do, it just takes definition in plugin.xml. Could you do it? Take a look at GLDErrorParser for example. - Those error parsers need JUnit test cases. I don't see one for VCErrorParser. Could you create one, the simplest example would be GLDErrorParserTests in org.eclipse.cdt.core.tests/misc/org.eclipse.cdt.core.internal.errorparsers.tests - If you work with VS, perhaps you could take a look at bug 79704, bug 157625, bug 161625, bug 246170? Thanks for the comments. I will work on all three points and also test with multiple versions of VS. I do wish for full support of VS and this might be the easiest place to start. Passing the task to sit on your plate. *** Bug 552455 has been marked as a duplicate of this bug. *** *** Bug 572436 has been marked as a duplicate of this bug. *** I never got to doing the change to regex parser and tests as it was always very low priority yet people keep getting the issue (myself included) so I'll just commit the small fix which is very safe anyway. New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/178792 Gerrit change https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/178792 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=8b3998eb4175a739277f3886e8f041f17378b59a |
Created attachment 174570 [details] Patch Tested with VS 2008 and .NET 3.5 Building with msbuild: c:\foo\main.cpp(5): error C2039 with devenv, cl: c:\foo\main.cpp(5) : error C2039