Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320108

Summary: [team] CVS commit comment is not getting populated from commit template
Product: z_Archived Reporter: Andrew Gvozdev <angvoz.dev>
Component: MylynAssignee: Project Inbox <mylyn-triaged>
Status: CLOSED MOVED QA Contact:
Severity: normal    
Priority: P3 CC: robert.elves
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 142280    

Description Andrew Gvozdev CLA 2010-07-16 10:04:14 EDT
In case when there was no files previously open - the CVS commit is not being populated with the template. My use case is as following:
- Receive a new bug in bugzilla with a patch
- Activate the task
- Apply the patch
- Review it in Synchronize view and be pleased with the changes
- Commit to CVS. At that point commit comment is empty.
Note that in this flow I did not open any normal editor, only compare editor.

I also noticed that in some cases the comment might get populated with data from a previous task I've been working on and sometimes I am getting 2 templates, from previous task on the top of comment and the current task template below it.
Comment 1 Steffen Pingel CLA 2010-07-16 13:55:50 EDT
Commit messages are based on changeset allocation, i.e. the file that you are committing needs to be in the corresponding changeset for the right comment to get generated. Is that the case when the the Syncrhonzie view to the Change Sets presentation?
Comment 2 Andrew Gvozdev CLA 2010-07-16 14:38:57 EDT
I am committing from left side of Synchronize perspective, that changeset which is showing there. Nothing funky, all default settings. As far as presentation, it is "All Models". But I also encountered that committing from Package Explorer from PDE perspective. My workaround so far was to open any file and the comment starts showing.

I was about to try with "Change Sets" presentation but it seems I can't reproduce it again. I'll try to do that next time it happens.
Comment 3 Andrew Gvozdev CLA 2010-07-30 23:02:34 EDT
Here is another case. When a commit consists only from removed files, the commit message is not populated again. Switching to Change Sets presentation did not make a difference.
Comment 4 Steffen Pingel CLA 2010-08-18 03:01:43 EDT
Please try toggling the presentation between incoming and outgoing mode the next time you see this problem and then try committing again. Please let me know if that does not resolve the problem.
Comment 5 Andrew Gvozdev CLA 2010-09-28 10:50:09 EDT
Looking at a slightly different case now. I was working with no task activated and changed some files - replaced 2 images. Now I figured that and activated the task. After that I try to commit the images and no commit message appears. I can see the source file which is open in the context but not my images. When I look at changeset presentation I see them under <Unassigned> in Synchronized view. Changing between Incoming/Outgoing makes no difference.
I try to change the source file with arbitrary change and do it again. Now the message appears. I remove the arbitrary change so the file is not in under synchronize list and the commit message is gone again.
Comment 6 Steffen Pingel CLA 2010-10-25 12:46:50 EDT
Which Eclipse and Mylyn versions are you using? Are you still seeing this with the latest 3.4.2 release?
Comment 7 Andrew Gvozdev CLA 2010-10-25 13:21:05 EDT
I update fairly regularly. Currently I have 3.5.0.I20101012-2200-e3x installed. The problem is still there, I just reproduced it. I did what described in comment 5 and the correct message appeared. Now I deactivated the task and activated a different one (happened a new one with no context yet). Now I synchronize and try to commit from synchronize view. The message is that from the previous task, not the currently active one. When I went to Package Explorer and commit from there the correct message appears and after that I see the correct one in the Synchronize view too.
Comment 8 Andrew Gvozdev CLA 2010-12-20 10:12:22 EST
This time my case was as following: I was into making changes and did not pay attention which task was active if any at all. Then I wanted to commit and take advantage of the commit message automatically populated, so I activated the proper task. That switched the current context and all the files got closed (that was the new context). Now I tried to commit and got no prepopulated comment. I switched to Synchronize perspective and tried to commit from there. No prepopulated comment. I toggled between incoming and outgoing mode as suggested in comment 4. Now the comment appeared in the commit dialog and I happily committed my code.
Comment 9 Steffen Pingel CLA 2011-04-05 14:39:44 EDT
My sense is that this is another incarnation of bug 142280. Andrew, please comment if you run into a case where toggling the presentation in the Synchronize view does not resolve the problem.
Comment 10 Andrew Gvozdev CLA 2011-04-05 15:06:06 EDT
(In reply to comment #9)
> My sense is that this is another incarnation of bug 142280. Andrew, please
> comment if you run into a case where toggling the presentation in the
> Synchronize view does not resolve the problem.

See comment 3 or comment 5 for easily reproducible examples. Just tried it and the comment is not populated. Toggling the presentation in the Synchronize view does not make a difference.

  Mylyn Commons	3.5.0.v20110316-0100	org.eclipse.mylyn.commons.feature.group
Comment 11 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn