Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320107

Summary: JSP Metamodel : CharacterDataElement is useless
Product: [Modeling] MoDisco Reporter: Fabien Giquel <fabien.giquel>
Component: TechnologiesAssignee: Fabien Giquel <fabien.giquel>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hugo.bruneliere, Kenn.Hussey, modisco.web-inbox, nicolas.guyomar
Version: 0.9.0Flags: fabien.giquel: indigo+
fabien.giquel: pmc_approved? (frederic.jouault)
Kenn.Hussey: pmc_approved+
Target Milestone: 0.9.0 M1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Removes CharacterDataElement from MoDisco JSP Meta Model fabien.giquel: iplog+

Description Fabien Giquel CLA 2010-07-16 09:49:26 EDT 
JSPComment may inherit directly from Node, as Comment.
JavaScript does not need to inherit from CharacterDataElement.

-> CharacterDataElement should be deleted.
The JSP discoverers and generator should be modified in consequence.
Comment 1 Nicolas Guyomar CLA 2010-07-16 10:08:21 EDT 
Hi Fabien, 

Please find attached the corresponding modification, those impact the following projects : 

org.eclipse.gmt.modisco.jee.jsp 
org.eclipse.gmt.modisco.jee.jsp.discoverer 
org.eclipse.gmt.modisco.jee.jsp.discoverer.tests 
org.eclipse.gmt.modisco.jee.jsp.generation 
org.eclipse.gmt.modisco.jee.jsp.generation.tests

Even if we are dealing with a minor modification in the Ecore, this results in quite a big patch because of the regeneration of the Metamodel implementation as well as the regeneration of the MoDisco JSP Lexer/Parser 


1. I, Nicolas Guyomar, and others contributors listed in this bug, authored
100% of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation

Regards

Nicolas
Comment 2 Nicolas Guyomar CLA 2010-07-16 10:09:09 EDT 
Created attachment 174493 [details]
Removes CharacterDataElement from MoDisco JSP Meta Model
Comment 3 Fabien Giquel CLA 2010-07-16 10:33:22 EDT 
Frederic,

here is a contribution from an employee of Mia-Software. The company has signed
a Member Commiter Agreement.

It is possible to commit this work without the need of a CQ, with the
confirmation that this work is done under PMC supervision.

Is it possible for you, or someone else of modeling PMC, to approve this work ?
Such a contribution deals with Java technologies reverse engineering. This
theme was planned in MoDisco roadmap ("Theme and priorities" of MoDisco project
plan).

Thanks in advance.
Comment 4 Fabien Giquel CLA 2010-07-22 13:23:16 EDT 
Kenn,

here is a contribution from an employee of Mia-Software. The company has signed
a Member Commiter Agreement.

It is possible to commit this work without the need of a CQ (as Sharon
confirmed it in older CQ
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3846#c9), with the
confirmation that this work is done under PMC supervision.

Is it possible for you, or someone else of modeling PMC, to approve this work ?
Such a contribution deals with Java/JEE technologies reverse engineering. This
theme was planned in MoDisco roadmap ("Theme and priorities" of MoDisco project
plan).
I will describe more precisely the proposed enhancement if you wish.

Thanks in advance.
Comment 5 Fabien Giquel CLA 2010-07-23 05:47:30 EDT 
Thanks for your contribution Nicolas,
thanks for your quick approval Kenn.

The code has been commited into SVN.
Comment 6 Hugo Bruneliere CLA 2010-10-05 04:20:57 EDT 
The patch has been successfully applied.