Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320064

Summary:

StyledText and CCombo should also use preceding CLabel as accessible name

Product:

[Eclipse Project] Platform

Reporter:

Carolyn MacLeod <carolynmacleod4>

Component:

SWT

Assignee:

Carolyn MacLeod <carolynmacleod4>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Silenio_Quarti

Version:

3.7

Keywords:

accessibility

Target Milestone:

3.6.1

Flags:

carolynmacleod4: review+

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch for StyledText and CCombo to use CLabel as name	none
patch	none

Description Carolyn MacLeod

2010-07-16 00:47:21 EDT

Currently, StyledText and CCombo will look to see if a Label precedes them in the z-order (i.e. the Label must be a sibling, and it must be created immediately before the StyledText or CCombo), and if so, then the Label text can be used for the StyledText or CCombo's default accessible name.

Comment 1 Carolyn MacLeod

2010-07-16 01:29:02 EDT

Created attachment 174467 [details]
patch for StyledText and CCombo to use CLabel as name

Comment 2 Carolyn MacLeod

2010-07-16 01:38:50 EDT

SSQ, please review for 3.6.1.

Here is a snippet:
import org.eclipse.swt.*;
import org.eclipse.swt.widgets.*;
import org.eclipse.swt.layout.*;
import org.eclipse.swt.custom.*;

public class CLabelAccessibleNameTest {
		
	public static void main(String[] args) {
		Display display = new Display();
		Shell shell = new Shell(display);
		shell.setLayout(new GridLayout(2, false));
		
		CLabel clabel = new CLabel(shell, SWT.NONE);
		clabel.setText("CLabel for the StyledText:");
		StyledText styledText = new StyledText(shell, SWT.SINGLE | SWT.BORDER);
		styledText.setText("Some text");

		CLabel clabel2 = new CLabel(shell, SWT.NONE);
		clabel2.setText("CLabel for the CCombo:");
		CCombo ccombo = new CCombo(shell, SWT.BORDER);
		ccombo.setItems(new String[] {"one", "two", "three"});
		ccombo.setText(ccombo.getItem(0));

		shell.pack();
		shell.open();
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch()) display.sleep();
		}
	}
}

Comment 3 Silenio Quarti

2010-08-04 17:44:06 EDT

Created attachment 175895 [details]
patch

Car, please try this patch out. Same idea but it avoids a couple of casts and instanceof checks.

It also fixes the fact that getAssociatedLabel() would loop through all siblings when the styledtext/ccombo is the first child and still return null.

Comment 4 Carolyn MacLeod

2010-08-06 09:43:01 EDT

I like that much better. I'll try it out when I get back.

Comment 5 Carolyn MacLeod

2010-08-24 10:51:39 EDT

Works great - thanks. I'll release for 3.6.1 and 3.7.

Comment 6 Carolyn MacLeod

2010-08-24 11:24:27 EDT

Fixed > 20100824 in HEAD for 3.7.

Comment 7 Carolyn MacLeod

2010-08-24 11:31:07 EDT

Fixed > 20100824 in 3.6.1 stream.