Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 320049

Summary:

Some of the form sections are collapsed by default when they should really be expanded

Product:

[Technology] Tigerstripe

Reporter:

Navid Mehregani <nmehrega>

Component:

Assignee:

Navid Mehregani <nmehrega>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

chrhartl, yuri

Version:

unspecified

Target Milestone:

0.5M0

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Navid Mehregani

2010-07-15 19:07:05 EDT

Build Identifier: 

Some of the form sections are collapsed by default when they should really be expanded.  Examples:
  - TS Project Descriptor > Overview > Project Defaults
  - TS Project Descriptor > Advanced Settings > Generation
  - TS Plugin Descriptor > Properties > Global Properties
  - TS Plugin Descriptor > Rules > Global Rules AND Artifact Rules

Reproducible: Always

Comment 1 Chris Hartley

2010-07-16 01:01:24 EDT

And AssociationClass Form --> attributes

(Jim Strawn and I fixed up most of these, these are just a few remaining ones)

Comment 2 Alena Repina

2010-07-26 04:42:01 EDT

Created attachment 175203 [details]
Patch

The patch makes following sections expanded by default:

- TS Project Descriptor > Overview > Project Defaults
- TS Project Descriptor > Advanced Settings > Generation
- TS Plugin Descriptor > Properties > Global Properties
- TS Plugin Descriptor > Rules > Global Rules AND Artifact Rules

Comment 3 Yuri Strot

2010-07-26 05:52:53 EDT

I've applied Alena's patch (fixes for Project/Plugin Descriptors).

I think Association Class editor should be consistent with other artifacts editors. If we want to show attributes/methods sections opened it should be done for all editors. But I think it makes sense to keep optional sections closed. It allows you to open only one necessary section without grabbing a lot of screen.

What do you guys think?

Comment 4 Navid Mehregani

2010-07-26 12:17:32 EDT

(In reply to comment #3)
> I've applied Alena's patch (fixes for Project/Plugin Descriptors).
> 
> I think Association Class editor should be consistent with other artifacts
> editors. If we want to show attributes/methods sections opened it should be
> done for all editors. But I think it makes sense to keep optional sections
> closed. It allows you to open only one necessary section without grabbing a lot
> of screen.
> 
> What do you guys think?

I honestly don't like the way Attributes and Methods are listed under Overview page.  I think they should have their own dedicated page in the editor and both sections should be expanded by default.  I also think we should remove the Constant section under Datatype and Entity editors (See bug#320922 for more details).  

I'll make a note of this in bug#320416.

Comment 5 Chris Hartley

2010-07-26 19:35:20 EDT

The sections we never use should remain closed.

I only asked for the sections that we do use to be opened (in my video).

Comment 6 Navid Mehregani

2010-07-26 21:51:33 EDT

(In reply to comment #5)
> The sections we never use should remain closed.
> 
> I only asked for the sections that we do use to be opened (in my video).

What are the sections that you don't use??

There are some sections that don't make sense to be collapsed irregardless of how often they're used.  For example, under TS Project Descriptor > Advanced Settings.  Generation is the only section on the page and it's collapsed by default.  There is no reason to collapse it when there is enough space to display its content.

Comment 7 Navid Mehregani

2011-02-22 15:31:42 EST

Marking as fixed.  All noted sections are expanded as expected.