Bugzilla – Full Text Bug Listing
| Summary: | new look - toolbar and persp switcher issues | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Susan McCourt <susan> | ||||||||
| Component: | UI | Assignee: | Susan McCourt <susan> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | Susan McCourt <susan> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | bokowski, gheorghe, remy.suen | ||||||||
| Version: | 1.0 | Flags: | bokowski:
review+
remy.suen: review+ |
||||||||
| Target Milestone: | 1.0 RC3 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows 7 | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 293481 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Susan McCourt
Created attachment 174424 [details]
Toolbar shown for an unselected window
On MacOS X, the toolbar gradient looks a bit jarring for unselected windows. Only if we're taking requests, of course.
(In reply to comment #0) > - global toolbar should be 32 pixels high from top of gradient to bottom > keyline It looks like this was already done. > - gutter space between bottom of global toolbar and top of panes should be 32 > pixels high I think this was a typo. The mockups show 24 and that seems much more reasonable to me. Changed stylesheets to use 24 at top and 12 (instead of 10) on sides. we might get some complaints about 24 being too much wasted space, 18 could be a compromise if that happens. Let's see what folks say... So the remaining issues here are: - global toolbar items should be faded to 50% opacity (Linda) - Mac only - why is the perspective switcher not the same as in other platforms? (Linda) - On MacOS X, the toolbar gradient looks a bit jarring for unselected windows (Brian) *** Bug 320257 has been marked as a duplicate of this bug. *** The top trim having more space than other trim areas seems kind of weird. It's not a huge deal for a workbench window but becomes very noticeable when working with detached windows. maybe we should be using the id of the workbench window so that this doesn't happen for all trim windows. I also want to see the overall feedback we get about having this much space for the workbench window. (In reply to comment #6) > maybe we should be using the id of the workbench window so that this doesn't > happen for all trim windows. Yes, I think ids/tags/whatever would be an appropriate solution here. Boris, OK for RC3? This is a stylesheet-only change. We use the IDE Window's id to ensure that the big margins are used only for workbench windows. I rather arbitrarily chose margins of 2px for other trimmed windows (detached windows). Created attachment 174807 [details]
tag top level windows 'topLevel'
+1 for making the change (but we should capture the stylesheet changes as attachments on this bug as well). yes, I intend to do so. I was getting ready to apply a patch when i realized that subsequently opened workbench windows weren't working...hence Eric's patch. Now I'll combine it all... Created attachment 174813 [details]
patch to renderer and new style sheets
Here is the complete patch. I verified that the initial IDE Window and subsequent workbench windows have the right margins. Detached windows have the 2px margins.
Remy, can you review? (it felt like cheating to ask Eric since he did the code part...) Looks good to me. committed to HEAD >201000721.(In reply to comment #3) I'd like to mark this fixed since something went in for RC3 and I've opened individual bugs for remaining issues: > So the remaining issues here are: > > - global toolbar items should be faded to 50% opacity (Linda) bug 320527 > - Mac only - why is the perspective switcher not the same as in other > platforms? (Linda) > - On MacOS X, the toolbar gradient looks a bit jarring for unselected windows > (Brian) bug 320528 verified on Win7, Build id: I20100726-2152 |