Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319999

Summary:	org.eclipse.cdt.core.ErrorParser pattern Extension Element Details editor does not properly handle quotes
Product:	[Eclipse Project] PDE	Reporter:	Austin Morgan <admorgan>
Component:	UI	Assignee:	PDE-UI-Inbox <pde-ui-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	major
Priority:	P3	CC:	angvoz.dev
Version:	3.6
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:	stalebug

Description Austin Morgan

2010-07-15 10:57:21 EDT

When adding patterns to my errorparser if I use quotes, the editor will modify the field every time I save it.

For example if I enter the string
scons:.*'(.*)' not found, needed by target .*
in the regex field when I save it will be modified to
scons:.*'(.*)' not found, needed by target .* target .*
and every time I press save it will be further modified
scons:.*'(.*)' not found, needed by target .* target .* target .*

Even if I completely remove the string and replace it with one with escaped quotes or no quotes after this has started it will continue to append the value.  So if I change the regex string to:
something completely different
After I save it will be
something completely different target .*

The value that is appended seems to be keyed off the location of the quotes, although I have not figured out the pattern completely.  This happens with any grouping of quotes that are not escaped.

I am using Helios on Linux, both 32 and 64bit versions

Comment 1 Andrew Gvozdev

2010-07-15 11:46:37 EDT

As I understand you are talking about PDE editor of plugin.xml.
Indeed, after entering a string and saving plugin.xml:

scons:.*'(.*)' not found, needed by target .*

I am getting at the end of line in plugin.xml extra characters (.*)'
      <errorparser>
         <pattern
               description-expr="$1"
               eat-processed-line="true"
               regex="scons:.*&apos;(.*)&apos; not found, needed by target .*(.*)&apos;"
               severity="Error">
         </pattern>
      </errorparser>

Which naturally shows as:

scons:.*'(.*)' not found, needed by target .*(.*)'

Comment 2 Andrew Gvozdev

2010-07-15 11:48:58 EDT

BTW that's org.eclipse.cdt.core.ErrorParser if it makes a difference.

Comment 3 Austin Morgan

2010-07-15 11:58:52 EDT

That is correct I was referring to the PDE Editor of plugin.xml

Comment 4 Andrew Gvozdev

2010-07-15 12:02:32 EDT

(In reply to comment #3)
> That is correct I was referring to the PDE Editor of plugin.xml
You have an easy workaround, just edit plugin.xml manually. I used to do that because of bug 293474  anyway. Or, even better, create them in Preferences->C/C++->Build and copy-paste the definitions from .metadata/.plugins/org.eclipse.cdt.core/model.extensions.xml.

Comment 5 Austin Morgan

2010-07-15 12:44:27 EDT

I had already worked around it by manually editing plugin.xml I just wanted to let the developers know there was an issue.

Thanks for the note about being able to dynamically create error parsers I was not aware of that.  It is very useful.

Comment 6 Eclipse Genie

2019-05-07 15:57:09 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.