Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319965

Summary:

New Feature Project->Referenced Plug-ins and Fragments multiselection functionality

Product:

[Eclipse Project] PDE

Reporter:

Petri Tuononen <petri.tuononen>

Component:

Assignee:

Curtis Windatt <curtis.windatt.public>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public

Version:

3.6

Keywords:

contributed

Target Milestone:

3.7 M2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Adds multiselection functionality and select and deselect buttons.	none
Improved. Now includes a double click listener to toggle between selected item state. Also separated SelectionListener to it's own method to make the code more compact.	none
Screenshot of button sizing	none
Screenshot of the New Feature Project page	none
Fixed patch	curtis.windatt.public: iplog+
Bug 319965 information sheet	none

Description Petri Tuononen

2010-07-15 06:20:26 EDT

Build Identifier: 20100617-1415

Currently when creating a new Feature Project and after clicking Next you get 'Referenced Plug-Ins and Fragments dialog' and you have to check every plug in separately, because there is no multiselection possibility. If someone wants to add many plug-ins to feature it's not very convenient.

Reproducible: Always

Steps to Reproduce:
1.Go to File->New->Other->Plug-In Development->Feature Project
2. Write Project name and click 'Next'
3. Now you can see 'Select All' and 'Deselect All' buttons or you can simply click a checkbox next to plugin name. There are no means to multiselect e.g. 10 plugins with two simple user actions for example highlighting wanted plugins.

Comment 1 Curtis Windatt

2010-07-15 08:57:08 EDT

I think that the check boxes are a better choice than simply having the user select entries.  However, buttons to select/deselect would be appropriate.  A double click listener would also help.

Perhaps you could provide a patch?

Comment 2 Petri Tuononen

2010-07-15 11:51:54 EDT

Yes, perhaps I could provide a patch. However I didn't quite understand what you meant about select/deselect buttons, because there's already select all and deselect all buttons. And what would a double click listener help?

Comment 3 Curtis Windatt

2010-07-15 11:57:14 EDT

I think that it is better to keep the checkboxes.  Adding in select/deselect buttons allows the user to multi-select then press the button to check/uncheck everything that is selected.  A double click listener to toggle the check state just adds a bit more convenience.

You can look at the export plug-ins wizard for an example of how a double click listener works.  Look at the target definition content tab for an example of how select/deselect buttons can interact with a checkbox table/tree.

Comment 4 Petri Tuononen

2010-07-21 15:52:54 EDT

Created attachment 174904 [details]
Adds multiselection functionality and select and deselect buttons.

The patch adds multiselection functionality and select and deselect buttons. However I forgot to implement a double click listener to deselect all or select just the clicked plugin but I might create an additional patch later.

Comment 5 Petri Tuononen

2010-07-22 13:21:36 EDT

Created attachment 175002 [details]
Improved. Now includes a double click listener to toggle between selected item state. Also separated SelectionListener to it's own method to make the code more compact.

Now the patch has all functionalities implemented as described in this Bug.

Comment 6 Curtis Windatt

2010-08-09 13:57:51 EDT

Created attachment 176172 [details]
Screenshot of button sizing

Functionality of the patch appears to work well, double clicking, selecting, etc. all works, however the buttons are out of place in Linux.  Petri, can you look at a fix for it?

Comment 7 Petri Tuononen

2010-08-15 11:49:51 EDT

Created attachment 176615 [details]
Screenshot of the New Feature Project page

Now the select and deselect buttons are places below select all and deselect all buttons. The screenshot is taken in Ubuntu 10.04.

Comment 8 Petri Tuononen

2010-08-15 11:54:35 EDT

Created attachment 176616 [details]
Fixed patch

Now the select and deselect buttons are places below the select all and deselect all buttons. This patch differs from the earlier. Now the select and deselect buttons are initialized in WizardCheckboxTablePart not in the PluginListPage.

Comment 9 Petri Tuononen

2010-08-15 12:52:57 EDT

Created attachment 176618 [details]
Bug 319965 information sheet

This pdf file shows the difference between the current New Feature view and the patched one and mentions the added functions.

Comment 10 Curtis Windatt

2010-08-20 15:42:15 EDT

Applied the fixed patch to HEAD.  Only change I had to make was to add mnemonics to the select/deselect buttons.

Comment 11 Ankur Sharma

2010-09-14 05:00:46 EDT

Verified in I20100913-1800