Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319950

Summary: ConvertToEMF doesn't work properly with many-valued EDataTypes
Product: [Modeling] EMF Reporter: Heiko Techteam <techteam>
Component: cdo.coreAssignee: Eike Stepper <stepper>
Status: CLOSED FIXED QA Contact: Eike Stepper <stepper>
Severity: normal    
Priority: P3 CC: nacor
Version: 4.0Keywords: needinfo
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
fix it, if values are in list
stepper: iplog+
Modified Attriubute test
stepper: iplog+
Test v3
none
Test+Fix - for future reference none

Description Heiko Techteam CLA 2010-07-15 03:30:24 EDT 
Build Identifier: 

The converter method of the custom CDOType get a ClassCastException, if you have defined your own datatype, and in your model you have a List of of values from this type.
While exporting data from CDO, it trys to convert data back to emf.
The method gets the EDataType and as value a CDOListImpl.
The CDOList could not be casted to String.

Reproducible: Always

Steps to Reproduce:
1. Define your own datatype (I get it with a dataytype from instance type BigDecimal)
2. Define in a model class a attribute with upper Bound > 1
3. Take a model instance into the CDO-Store
4. Try Export the data
Comment 1 Heiko Ahlig CLA 2010-07-15 14:40:14 EDT 
Attached Patch should fix the problem if the custom values are in a CDOList.
Comment 2 Heiko Ahlig CLA 2010-07-15 14:41:15 EDT 
Created attachment 174433 [details]
fix it, if values are in list
Comment 3 Eike Stepper CLA 2010-07-16 04:01:02 EDT 
Comment on attachment 174433 [details]
fix it, if values are in list

Heiko, please confirm that:

1) The number of lines that you changed is smaller than 250.
2) You are the only author of these changed lines.
3) You apply the EPL to these changed lines.
Comment 4 Eike Stepper CLA 2010-07-16 04:27:55 EDT 
I added test case org.eclipse.emf.cdo.tests.AttributeTest.testManyValuedCustomDataType_Bugzilla_319950() and it does not fail.

Heiko, please look at it and try to explain why it does not fail. Or better, provide a test case that reproduces your exact problem, then reopen this bug.
Comment 5 Eike Stepper CLA 2010-07-16 04:28:39 EDT 
Problem is not reproducible.
Comment 6 Eike Stepper CLA 2010-07-16 04:31:47 EDT 
Comment on attachment 174433 [details]
fix it, if values are in list

CDOType is not concerned with the many-valued aspect of features. I think if a list arrives in a CDOType method this should be fixed elsewhere. I'm also not sure if replacing a CDOListImpl with a BasicEList is a good idea.
Comment 7 Heiko Ahlig CLA 2010-07-16 19:05:14 EDT 
Created attachment 174546 [details]
Modified Attriubute test

Hi Eike, 
I have seen your Test and hav it modified so the he reproduced the error.

I found this error, when I tried to use the 
org.eclipse.emf.cdo.internal.ui.actions.ExportResourceAction 

From there I also copied the function to reproduce.
In the first patch I use the BasicEList, because it should export to a file.


Where are the point to reopen the bug?
Comment 8 Eike Stepper CLA 2010-07-26 02:38:50 EDT 
These two lines are able to show the problem:

    EList<EObject> contents = resource.getContents();
    EcoreUtil.copyAll(contents);
Comment 9 Eike Stepper CLA 2010-07-26 02:40:33 EDT 
Created attachment 175196 [details]
Test v3
Comment 10 Eike Stepper CLA 2010-07-26 02:57:26 EDT 
Created attachment 175197 [details]
Test+Fix - for future reference

The problem was in CDOStore.isSet() where the many-valued feature was accessed with get(feature, NO_INDEX).

NO_INDEX must only be used with single-valued features.
Comment 11 Eike Stepper CLA 2010-07-26 02:57:58 EDT 
Committed to HEAD
Comment 12 Eike Stepper CLA 2010-09-23 04:07:26 EDT 
Heiko, please confirm that:

1) The number of lines that you changed is smaller than 250.
2) You are the only author of these changed lines.
3) You apply the EPL to these changed lines.

Otherwise we get into trouble with the legal department ;-(
Comment 13 Heiko Techteam CLA 2010-09-23 05:45:51 EDT 
I confirm that:
1) The number of lines that I changed is smaller than 250.
2) I'm the only author of these changed lines.
3) I apply the EPL to these changed lines.
Comment 14 Eike Stepper CLA 2010-09-23 06:05:25 EDT 
Comment on attachment 174546 [details]
Modified Attriubute test

Thx ;-)
Comment 15 Eike Stepper CLA 2011-06-23 03:41:38 EDT 
Available in R20110608-1407