Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319947

Summary:	Confirmation for Reset
Product:	[Technology] EGit	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	b.muskalla, jens.baumgart, Lars.Vogel, matthias.sohn
Version:	0.9.0
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Lars Vogel

2010-07-15 02:53:08 EDT

The EGit context menu shows:

- Branch
- Tag
- Reset

AFAIK Reset does set the repo to the last committed state.

I suggest the following change:

 - Move Reset apart from Branch and Tag, to avoid that someone accidentally select this menu entry. 

- Include a confirmation dialog before executing the command

Best regards, Lars

Comment 1 Jens Baumgart

2010-07-15 05:29:40 EDT

Hi Lars,

do you mean the Team Menu? Team->Reset... shows a dialog. In case of a hard reset the user is warned about loosing working tree changes.
I found that Reset->Hard in History view does not send a confirmation dialog.

Best regards

Jens

Comment 2 Lars Vogel

2010-07-15 05:35:13 EDT

Hi Jens,

yes, I meant: I Reset->Hard in History view

Thank you, Lars

Comment 3 Jens Baumgart

2010-07-15 06:02:40 EDT

Fix proposed: http://egit.eclipse.org/r/1133

Comment 4 Matthias Sohn

2010-07-16 10:36:50 EDT

merged as 375143d409b6145962e226a61a14f97cae4fcaf8