Bugzilla – Full Text Bug Listing
| Summary: | Refactoring: Add Use Statement to Module | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Matthew Fotzler <incongruous> | ||||||
| Component: | Photran.Refactoring Engine | Assignee: | Matthew Fotzler <incongruous> | ||||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P2 | CC: | akasza2, com-eclipse-dot-org | ||||||
| Version: | 6.0 | ||||||||
| Target Milestone: | 7.0 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 321790 | ||||||||
| Attachments: |
|
||||||||
Thanks. Matt and Ashley, can you *both* please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files? Yes, I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, I have the right to contribute the code to Eclipse, and I have included the EPL license header in all source files. 1. I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. I have the right to contribute the code to Eclipse, and 3. I have included the EPL license header in all source files. There is at least one problem with this patch... I imagine we will likely find more as we complete the Move Module Entity refactoring. So I will wait until we finish that and hopefully just update this patch once. Created attachment 179327 [details]
Revised patch - renamed, merged with other changes
There were several conflicts trying to commit this to CVS. I think I resolved them, but the unit tests are not passing, so I did not commit the refactoring itself or the
test suite. Matt, could you please replace your sources from HEAD (i.e., get
rid of your local changes), then apply the REVISED patch (attached), and see
why the tests are failing? When it is fixed, please attach a revised revised
patch. Thanks.
Change of plans -- we will treat this as part of Move Module Entities (Bug 321790) and send it through IP review as part of that patch/refactoring. *** This bug has been marked as a duplicate of bug 321790 *** |
Created attachment 174315 [details] refactoring and test suite patch This refactoring adds a use only statement to the target module M' if it doesn't already exist, giving access to the entities in E from module M.