Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319870

Summary:

[Compatibility] Unable to close the SDK when all perspectives are closed

Product:

[Eclipse Project] e4

Reporter:

Susan McCourt <susan>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

RESOLVED FIXED

QA Contact:

Remy Suen <remy.suen>

Severity:

major

Priority:

CC:

remy.suen

Version:

1.0

Target Milestone:

1.0 RC2

Hardware:

OS:

Windows All

Whiteboard:

Attachments:

Description	Flags
log file showing steps. I had cleaned the log just before all this happened, so the entire log is relevant	none

Description Susan McCourt

2010-07-14 11:35:25 EDT

Created attachment 174306 [details]
log file showing steps.  I had cleaned the log just before all this happened, so the entire log is relevant

I20100713-2016, Win7.
I was playing around with perspective scenarios to see where we stand on bug 317203.  I think I did something like this (will try again, but want to capture the steps while I sort of remember them)

- I had CVS, Team, and Java perspectives open
- I tried closing all perspectives and ended up with a bunch of empty part stacks
- The perspective switcher showed the perspectives still.
- Then I tried close all perspectives
- all the stack disappeared
- I reopened the java perspective but there was no content in the package explorer
- I tried Project->Clean just to see if the workbench thought it had a workspace (since there was no data) 
- At this point I was pretty hosed, and could not close the SDK
- had to kill it with the task manager
- I'll attach the log

I will start over and come up with reproducible steps, I'm not sure I'm remembering the sequence exactly right but wanted to capture it.

Comment 1 Susan McCourt

2010-07-14 11:46:02 EDT

Here's a scenario.  I'm sure I can simplify it further.

- fresh workspace
- open CVS perspective
- add a repo connection
- close CVS persp from switcher
- close Java persp from switcher
- part stacks go empty, followed by a total cleanup.  
- when I reopen the CVS persp, the connection is still there
- check out the org.eclipse.e4.core.commands bundle
- back to Java perspective
- Team->Synchronize, yes to go to team perspective
- Window->Close all 
- get a widget disposed error
- now I can't switch workspaces or otherwise close the SDK, getting NPE's

Comment 2 Remy Suen

2010-07-14 13:23:58 EDT

This is on XP using I20100713-2016 pointing at a new workspace.

1. Window > Open Perspective > Debug
2. Window > Close Perspective
3. Window > Close Perspective
4. Window > Open Perspective > Other... > Java
5. Note that a new workbench window has been spawned.
6. Alt+F4 on the new one.
7. Alt+F4 on the original, confirm and so on.
8. You will not be able to close this due to some NPE loop.

Comment 3 Susan McCourt

2010-07-14 13:38:58 EDT

variation of above,
Win7, I20100713-2016 pointing at a new workspace.

1. Window > Open Perspective > Debug
>>2. Window > Close All perspectives
>>3. Note you get one large empty part stack rather than having no stacks
4. Window > Open Perspective > Other... > Java
5. Note that a new workbench window has been spawned.
6. Alt+F4 on the new one.
7. Alt+F4 on the original, confirm and so on.
8. You will not be able to close this due to some NPE loop.

Comment 4 Susan McCourt

2010-07-14 13:42:17 EDT

Even more basic.
Win7, I20100713-2016 pointing at a new workspace.

1. Window->Close all perspectives
2. Note you get one large empty part stack rather than having no stacks
3. You cannot exit the workbench

Comment 5 Remy Suen

2010-07-14 13:52:41 EDT

There are a lot of problems here. The main one being that closing the last perspective completely hoses the workbench window.

Comment 6 Remy Suen

2010-07-14 14:22:23 EDT

The steps in comment 4 are now working.

The extra workbench window spawning problem is now under investigation.

Comment 7 Remy Suen

2010-07-14 16:30:03 EDT

Comment 2 now works. Comment 3 is a little iffy. I've seen it get into the NPE case and if it doesn't, the editor area is still there despite the fact that (all) the perspectives have been closed.

Comment 8 Remy Suen

2010-07-14 19:44:50 EDT

Comment 3 works too now. I am inclined to believe that 'Close All Perspectives' was the culprit behind comment 0 and comment 1. You should now get a completely "empty" window instead of an empty part stack (the editor area).

Thank you for finding this bug in the 4.0 workbench implementation, Susan.