Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319796

Summary: SWTGraphics#clipPath(Path) need to ensure the path is closed
Product: [Tools] GEF Reporter: Alex Boyko <aboyko>
Component: GEF-Legacy Draw2dAssignee: Alex Boyko <aboyko>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, lgrahek
Version: 3.6   
Target Milestone: 3.6.1 (Helios SR1)   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
patch aboyko: review?

Description Alex Boyko CLA 2010-07-13 18:48:19 EDT
Created attachment 174242 [details]
patch

#clipPath(Path) requires the Path to be explicitly closed whyle #setClip(Path) doesn't. The new clipPath(Path) should accept the same input as setClip(Path)

Tested out, seems to be working.

Lidija, can you please review?
Comment 1 Alex Boyko CLA 2010-07-13 20:26:12 EDT
Created attachment 174243 [details]
patch

The problem is not the Path is not closed but rather that there is a typo in loadPath(Region, float[], int[]) utility method.
Lidija, can you please review this patch?
Comment 2 Lidija Grahek CLA 2010-07-14 11:57:50 EDT
Looks good Alex.
Comment 3 Alex Boyko CLA 2010-07-14 12:16:14 EDT
Thanks! I delivered to 3.6 maintenance and HEAD