Bugzilla – Full Text Bug Listing
| Summary: | Manifest Entries page does not list the entries in the correct order | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Common Tools | Reporter: | Jason Peterson <jasonpet> | ||||
| Component: | wst.common | Assignee: | Jason Peterson <jasonpet> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Carl Anderson <ccc> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david_williams, jsholl | ||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
jasonpet: pmc_approved? (raghunathan.srinivasan) jasonpet: pmc_approved? (naci.dai) deboer: pmc_approved+ jasonpet: pmc_approved? (neil.hauge) jasonpet: pmc_approved? (kaloyan) ccc: review+ |
||||
| Target Milestone: | 3.2.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | PMC_approved | ||||||
| Attachments: |
|
||||||
I approve of this change. When it comes to MANIFEST.MF entries, ordering is extremely important. * Explain why you believe this is a stop-ship defect. Or, if it is a
"hotbug" (requested by an adopter) please document it as such.
The list of manifest entries from the manifest entries tab of the deployment assembly page does not list the entries in the order they are listed in the MANIFEST.MF file. Ordering is very important for these entries.
* Is there a work-around? If so, why do you believe the work-around is
insufficient?
The only work-around is for the user to open the actual MANIFEST.MF file with a text editor to verify ordering.
* How has the fix been tested? Is there a test case attached to the
bugzilla record? Has a JUnit Test been added?
Fix has been tested in the UI.
* Give a brief technical overview. Who has reviewed this fix?
The manifest entries tab of the deployment assembly page lists the entries in the order they are returned by calling component.getReferences(). This does not match the actual order they appear in the MANIFEST.MF. The user can reorder them in this page and it correctly writes it out. However, when reopening the editor it always appear as it did before since it is ordering by the call to component.getReferences().
Carl has reviewed this fix.
* What is the risk associated with this fix?
minimal - fix was to simply order the references in the same order as they appear in the actual MANIFEST.MF.
code checked into head for wtp 3.2.1 |
Created attachment 174232 [details] patch The new manifest entries page added in 3.2 is not reading the list of entries in the order they appear in Manifest. It builds up the list by adding references in the order they are returned by calling component.getReferences() and then adds any dummy references specified in the actual Manifest. The fix was sort the list of references in the same order they are listed in the actual file.