Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319786

Summary: Change API freeze check in 3.6.x stream to compare against 3.6
Product: [Eclipse Project] Platform Reporter: Kim Moir <kim.moir>
Component: RelengAssignee: Kim Moir <kim.moir>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, darin.eclipse, Olivier_Thomann
Version: 3.6.1   
Target Milestone: 3.6.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
patch
none
patch to compare against 3.6 none

Description Kim Moir CLA 2010-07-13 16:07:19 EDT
Currently it's disabled. Previously it compared against 3.6M6.
Comment 1 Kim Moir CLA 2010-07-13 16:11:40 EDT
Created attachment 174228 [details]
patch
Comment 2 Dani Megert CLA 2010-07-14 02:01:17 EDT
This report is useless as the same information is in the 'API Tools Version Verification Report'. Please remove it.

However, as Olivier already pointed out, we must use 3.6.0 as the baseline for the 'API Tools Version Verification Report'.
Comment 3 Kim Moir CLA 2010-07-14 07:12:06 EDT
Verified in test build and released for M20100714-0800.
Comment 4 Kim Moir CLA 2010-07-14 07:31:45 EDT
Didn't see second comment, reopening to fix.
Comment 5 Kim Moir CLA 2010-07-14 08:56:58 EDT
Created attachment 174287 [details]
patch

patch to remove
Comment 6 Kim Moir CLA 2010-07-14 09:50:48 EDT
Created attachment 174290 [details]
patch to compare against 3.6
Comment 7 Darin Wright CLA 2010-07-14 10:37:47 EDT
I discussed with Dani/Olivier. The "freeze" report should be performed in the build as the "verification" report will not detect API changes that are compatible and where are bundle version is incremented appropriately.

The IDE tooling provides developers with quick fixes to update bundle versions as API is added in compatible ways. Thus, it would be possible for a developer to make a mistake, and add API in a way that the "verification" report would not detect. In general, developers should not do this (and know better). However, to be safe, we might as well use the report to verify no unintended API changes slip through.
Comment 8 Dani Megert CLA 2010-07-14 11:54:25 EDT
I agree. The report will be useful to blame evil committers ;-)
Comment 9 Kim Moir CLA 2010-07-20 16:32:28 EDT
released for M20100721-0800