Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319731

Summary: Cannot change the deploy path of Utility, JPA and ejb client jars using the deployment assembly page of EAR
Product: [WebTools] WTP Java EE Tools Reporter: Aidyl Kareh <amkareh>
Component: jst.j2eeAssignee: Aidyl Kareh <amkareh>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: amkareh, david_williams, jsholl
Version: unspecifiedFlags: david_williams: pmc_approved+
amkareh: pmc_approved? (raghunathan.srinivasan)
amkareh: pmc_approved? (naci.dai)
deboer: pmc_approved+
amkareh: pmc_approved? (neil.hauge)
amkareh: pmc_approved? (kaloyan)
cbridgha: review+
Target Milestone: 3.2.1   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
Proposed Patch none

Description Aidyl Kareh CLA 2010-07-13 10:29:04 EDT 
Build Identifier: WTP 3.2.1

The problem is that changes made to the deploy path of projects mapped to library directory folder in the 'Deployment Assembly' properties page of the EAR are not saved. The deploy path keeps defaulting to the value of the library directory regardless of any user specified deploy path.

Steps to recreate:
1. Create an EAR 5 or 6 with default modules
2. Add an utility project, and an JPA project to the ear
3. Create the ejb client jar to the ejb module
4. Go to the deployment assembly page of the EAR. Note that the Utility, JPA and EJB client are mapped to /lib
5. Change the deploy path of any of the modules in /lib (change it to /test instead of /lib) and click OK
6. Open the deployment assembly page of the EAR again, Note that the deployment path is still /lib

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-07-13 10:38:02 EDT 
Created attachment 174156 [details]
Proposed Patch

Patch adds code to set the TARGET_COMPONENTS_DEPLOY_PATH_MAP with the user specified deploy paths in the AddReferenceToEnterpriseApplicationDataModelProvider.setMissingProperties() method.
Comment 2 Chuck Bridgham CLA 2010-07-13 14:13:09 EDT 
approved
Comment 3 Aidyl Kareh CLA 2010-07-13 14:19:10 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

The 'Deployment Assembly' properties page allows the user to change the deploy path for all types of projects and these changes should be saved. The defect is that changes made to the deploy path of utility projects in the 'Deployment Assembly' properties page of the EAR are not saved. The deploy path keeps defaulting to the value of the library directory regardless of any user specified deploy path.


    * Is there a work-around? If so, why do you believe the work-around is
insufficient? 

The user would have to go make the deploy path changes directly on the 'org.eclipse.wst.common.component' file. If the user later uses the 'Deployment Assembly' properties page to change the deploy path of the utility projects then it would again default to the library directory folder.


    * How has the fix been tested? Is there a test case attached to the
bugzilla record? Has a JUnit Test been added?

Tested through UI.


    * Give a brief technical overview. Who has reviewed this fix? 

This patch adds code to set the TARGET_COMPONENTS_DEPLOY_PATH_MAP property with the user specified deploy paths for all projects instead of using the default property value for utility projects. Chuck Bridgham reviewed this patch.


    * What is the risk associated with this fix? 

None
Comment 4 Jason Sholl CLA 2010-07-14 10:36:28 EDT 
code checked into head for wtp 3.2.1