Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319729

Summary: Toolbar uses two rows (wraps) but has lots of empty space
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt, ob1.eclipse, pwebster, stojan.sljivic
Version: 4.1   
Target Milestone: 4.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
This is the correct state none

Description Dani Megert CLA 2010-07-13 10:27:42 EDT 
SDK 4.0 - I20100712-2029.

The toolbar uses two rows (wraps) but has lots of empty space. This is a waste  of my vertical screen real-estate.

Test Case:
1. start with new workspace
2. create Java project and a class
==> editor opens and toolbar wraps
Comment 1 Eric Moffatt CLA 2010-07-13 13:15:58 EDT 
This is an issue with us rendering empty TB's I believe. The defect isn't in the wrapping calculations or in not compressing the layout of the tip trim, it's actually laying out what is really there.
Comment 2 Dani Megert CLA 2010-09-22 05:42:05 EDT 
This got worse. In 20100921-1710 this even happens with a completely new workspace.
Comment 3 Dani Megert CLA 2011-11-07 09:28:29 EST 
(In reply to comment #2)
> This got worse. In 20100921-1710 this even happens with a completely new
> workspace.

That part seems fixed again in Juno M3.
Comment 4 Paul Webster CLA 2012-04-18 10:44:06 EDT 
Created attachment 214186 [details]
This is the correct state

Oleg says there's another state with gaps, he'll include a snapshot.

PW
Comment 5 Oleg Besedin CLA 2012-04-18 11:20:13 EDT 
(In reply to comment #4)
> Oleg says there's another state with gaps, he'll include a snapshot.

With the code from master I can not reproduce the problem anymore. It used to be that I'd get a blocks of empty space in the toolbar, but things seem to work fine for me now.
Comment 6 Dani Megert CLA 2012-04-19 03:36:41 EDT 
> (In reply to comment #5)
> With the code from master I can not reproduce the problem anymore. It used to
> be that I'd get a blocks of empty space in the toolbar, but things seem to 
> work fine for me now.

Same here using 4.2-N20120418-2000.
Comment 7 Stojan Sljivic CLA 2012-10-29 14:56:39 EDT 
The issue is still present in the Juno build 20121004-1855.
Comment 8 Paul Webster CLA 2012-10-29 15:00:55 EDT 
(In reply to comment #7)
> The issue is still present in the Juno build 20121004-1855.

That's a different bug.  Please open a new bug with a screenshot.

PW
Comment 9 Stojan Sljivic CLA 2012-10-29 18:23:03 EDT 
(In reply to comment #8)
> (In reply to comment #7)
> > The issue is still present in the Juno build 20121004-1855.
> 
> That's a different bug.  Please open a new bug with a screenshot.
> 
> PW


Created new bug #393105.