Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319580

Summary:	Open Plug-in Artifact dialog shows wrong labels
Product:	[Eclipse Project] PDE	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ankur_sharma, curtis.windatt.public
Version:	3.6
Target Milestone:	3.7 M1
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Markus Keller

2010-07-12 10:27:34 EDT

I20100706-0800

- new workspace
- add all plug-ins to Java search
- Open Plug-in Artifact...
- type "*.contentTypes"
=> labels look OK
- press Arrow Down key twice
=> label for first entry changed from org.eclipse.core.contentTypes to org.eclipse.runtime.contentTypes

The bug is in the implementation of org.eclipse.pde.internal.core.plugin.PluginExtensionPoint#equals(Object), which doesn't compare enough properties.

In this case, comparing getFullId() or getParent() would fix the problem, but there may be more properties missing.

Comment 1 Curtis Windatt

2010-07-12 12:44:08 EDT

Using getFullID instead of getID makes sense here.

Comment 2 Curtis Windatt

2010-07-12 12:46:58 EDT

Fixed in HEAD.

As Markus says, there could be other properties included in the equals, but id, name and schema should be enough.

Comment 3 Ankur Sharma

2010-08-03 05:22:27 EDT

Verified in I20100802-1800