Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319536

Summary:

[preferences] Indicate 'Smart Insert Mode' options on 'Typing' preference page

Product:

[Eclipse Project] JDT

Reporter:

Dani Megert <daniel_megert>

Component:

Text

Assignee:

Rajesh <rthakkar>

Status:

VERIFIED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

deepakazad, markus.kell.r

Version:

3.4

Target Milestone:

3.7 M2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none
Patch	daniel_megert: review-
Fix	daniel_megert: iplog+, daniel_megert: review+

Description Dani Megert

2010-07-12 07:05:23 EDT

The options that can be disabled (and enabled again) via 'Edit' > 'Smart Insert Mode' should be indicated on the 'Typing' preference page.

Comment 1 Rajesh

2010-08-25 04:03:47 EDT

Created attachment 177389 [details]
Patch

Here is one way to do it. Not sure about the language in the message, but did look around as to how a 'Menu' item is referred to in these pages.

Comment 2 Dani Megert

2010-08-25 11:38:02 EDT

Thanks for the patch Rajesh. I'll have to verify whether indeed all preferences are affected by the Smart Insert mode. If so, we should probably simply rename the preference page.

Comment 3 Rajesh

2010-08-25 12:19:04 EDT

Created attachment 177440 [details]
Patch

(In reply to comment #2)
> Thanks for the patch Rajesh. I'll have to verify whether indeed all preferences
> are affected by the Smart Insert mode. If so, we should probably simply rename
> the preference page.

I did verify each one, but it would be great if you could do the same. Attaching new patch fixing a typo in Javadoc statement.

Comment 4 Dani Megert

2010-08-30 06:13:19 EDT

Comment on attachment 177440 [details]
Patch

The patch is not good for two reasons:
1. The margin is wrong: if you look at other top sentences you'll see the difference.

2. One of the preferences is not yet controlled by the 'Smart Insert' setting. Either test them manually or look at the code.


I would also change the wording a bit, e.g.:
The preferences on this page are only considered if 'Edit' > 'Smart Insert Mode' is selected.

Comment 5 Rajesh

2010-09-01 01:00:03 EDT

Created attachment 177913 [details]
Fix

Now 'Update Imports' is also controlled via 'Smart Insert Mode'. Also, modified the text and its margins.

Comment 6 Dani Megert

2010-09-01 07:00:34 EDT

Fixed missing copyright update and committed to HEAD.
Available in builds >= N20100901-2000.

Comment 7 Markus Keller

2010-09-07 10:49:00 EDT

Changed message in HEAD to "... 'Edit > Smart Insert Mode' ...".

Comment 8 Dani Megert

2010-09-14 08:51:49 EDT

Verified in I20100914-0100. Changed the string to
  "The preferences on this page are only considered if 'Smart Insert Mode' is 
  selected."
and updated the F1 help.

Filed bug 325242 to update the documentation for the 'Typing preference page'.