Bugzilla – Full Text Bug Listing
| Summary: | [metatype] should use OSGi logging | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Bryan Hunt <bhunt> | ||||||||
| Component: | Compendium | Assignee: | John Ross <jwross> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | tjwatson | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | 3.7 M3 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Tom, can we get this into 3.7? John, could you take a look at this? Created attachment 180393 [details]
logging patch 2
I made some updates to the original patch. For the sake of consistency, I reused the LogTracker class as in several other implementations such as ConfigAdmin, Device, EventAdmin, HTTP, and UserAdmin. This class will log to all registered LogService instances or, if none, to System.out/System.err. Also, I passed the LogTracker as a constructor arg to the various objects instead of turning the Activator into a virtual LogService retrieved from a getInstance() method.
Bryan, thanks for the report and patch. Please let me know if the updated patch does not suit your needs.
Tom, BJ, there appear to be some other issues with the code that I did not attempt to address here. The updated patch focuses exclusively on the original intent of this bug.
Created attachment 180465 [details]
logging patch 3
Minor change to pass the more generic LogService type instead of LogTracker to other objects. LogTracker is essentially a composite LogService.
Updated patch looks good. I updated the copyright dates and released the patch. Thanks Bryan and John for the contributions! |
Created attachment 173989 [details] logging patch The metatype service currently uses a home-grown logging service. It should use the OSGi logging service.