Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319473

Summary: [eclipse-build] [debian] Extract the SWT libraries (.so files) after installation
Product: [Tools] Linux Tools Reporter: Benjamin Drung <bdrung>
Component: eclipse-buildAssignee: Packaging Tools Inbox <linux.packagingtools-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, overholt
Version: unspecified   
Target Milestone: 0.6.1   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
generate-metadata-and-extract-swt-libraries.patch
none
generate-metadata-and-extract-swt-libraries2.patch
overholt: iplog+
remove-unnecessary-files.patch
overholt: iplog+
strip-destDir.patch
none
strip-destDir2.patch
none
strip-destDir3.patch none

Description Benjamin Drung CLA 2010-07-10 18:46:41 EDT
Created attachment 173951 [details]
generate-metadata-and-extract-swt-libraries.patch

Please generate metadata and extract the swt libraries after installation. I will attach three patches. The first will generate metadata and extract the swt libraries. The second will remove some files that are automatically generated by these calls and are not needed. The third one is for correcting the path to not include ${destDir}.
Comment 1 Benjamin Drung CLA 2010-07-10 18:48:35 EDT
Created attachment 173952 [details]
generate-metadata-and-extract-swt-libraries2.patch

The first version generate-metadata-and-extract-swt-libraries.patch lacks the extract_patterns.txt file.
Comment 2 Benjamin Drung CLA 2010-07-10 18:53:17 EDT
Created attachment 173953 [details]
remove-unnecessary-files.patch
Comment 3 Benjamin Drung CLA 2010-07-10 19:44:06 EDT
Created attachment 173955 [details]
strip-destDir.patch
Comment 4 Benjamin Drung CLA 2010-07-10 19:46:26 EDT
Created attachment 173956 [details]
strip-destDir2.patch

strip-destDir2.patch is a -p0 patch now.
Comment 5 Benjamin Drung CLA 2010-07-11 11:10:11 EDT
Created attachment 173978 [details]
strip-destDir3.patch

Fixed strip destDir patch.
Comment 6 Andrew Overholt CLA 2010-07-19 16:47:36 EDT
Thanks for the patches.  In the future, please split bugs up along patch lines so it's easier to deal with single issues on their own :)  As such, please open a second bug for the stripping of ${destDir}.

For the metadata-generation, I think we need to have a separate target, 'provision.platform' which uses the p2 director to provision only the Eclipse Platform.  There may already be metadata for it, too, so please ensure it's not there before re-generating it.  This will enable the distributions to install just the Eclipse Platform and, for example, put JDT and PDE into dropins or some other similar solution.

In revision I've applied the parts of the patches that extract the .so files and the cleanup of the files that that operation generates.  I'll close this bug (which I've re-named) and we can take care of the other issues in other bugs.
Comment 7 Andrew Overholt CLA 2010-07-19 16:48:10 EDT
Comment on attachment 173952 [details]
generate-metadata-and-extract-swt-libraries2.patch

Marking iplog+ even though it wasn't applied exactly as submitted.
Comment 8 Andrew Overholt CLA 2010-07-19 16:48:13 EDT
Comment on attachment 173953 [details]
remove-unnecessary-files.patch

Marking iplog+ even though it wasn't applied exactly as submitted.
Comment 9 Andrew Overholt CLA 2010-07-19 17:10:26 EDT
Oops, forgot to include the SVN revision (25285) above.  I've put it inline below.

(In reply to comment #6)
> In revision #25285 I've applied the parts of the patches that extract the .so files
Comment 10 Andrew Overholt CLA 2010-08-10 16:13:41 EDT
Original patch #3 split off into bug #322283.