Bugzilla – Full Text Bug Listing
| Summary: | Remove dead code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Schindl <tom.schindl> | ||||
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | bokowski, emoffatt, john.arthorne, Lars.Vogel, pwebster | ||||
| Version: | 4.2.1 | Flags: | pwebster:
review+
|
||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 420779 | ||||||
| Attachments: |
|
||||||
+1, but we should let Eric comment on the model stuff. PW +1 from me too. Eric? Though I have already 2 1+ I want to reiterate because we are now in rc3 and I'm not sure you still vote +1. Eric was missing anyway. I would prefer that we do this after 4.0. As was as I can see, the code is still unused. Would be nice to get it removed. Looks OK to me...does anyone know whether the patch is still good or does it need to be upgraded ? No, does not apply anymore. Just delete the ModelService.java, ModeledContentProvider, ModeledLabelProvider classes. Looks to me RunAway is already deleted. Thanks Lars, will do... I get errors from this commit: Description Resource Path Location Type The major version should be incremented in version 1.1.0, since API breakage occurred since version 1.0.0 MANIFEST.MF /org.eclipse.e4.ui.workbench/META-INF line 4 Version Numbering Problem The type org.eclipse.e4.ui.workbench.modeling.ModelService has been removed from org.eclipse.e4.ui.workbench_1.1.0 MANIFEST.MF /org.eclipse.e4.ui.workbench/META-INF line 1 Compatibility Problem Since the class itself said @noreference you should probably just add a commented api filter and put the bug # - title in it. PW Thanks Paul, will do so. Just need to figure out how to add a commented API filter. You should have an API baseline set in PDE prefs (4.4 baseline is against 4.3.0) ... then a quick-fix on the errors creates the filters. PW (In reply to Paul Webster from comment #13) > You should have an API baseline set in PDE prefs (4.4 baseline is against > 4.3.0) ... then a quick-fix on the errors creates the filters. > > PW Thanks. This is new to me, can you check the Gerrit review? https://git.eclipse.org/r/21572 The tooling seems to have removed a block in the API tooling. I find it hard to tell if that is correct or not. |
Created attachment 173938 [details] patch The classes attached to this patch are not used and I think we can remove them